Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to save and retrieve Companion Telemetry Simulator values #1950

Closed
1 task done
dwheeld opened this issue May 10, 2022 · 7 comments · Fixed by #1954
Closed
1 task done

Add a method to save and retrieve Companion Telemetry Simulator values #1950

dwheeld opened this issue May 10, 2022 · 7 comments · Fixed by #1954
Labels
companion Related to the companion software enhancement ✨ New feature or request

Comments

@dwheeld
Copy link
Contributor

dwheeld commented May 10, 2022

Is there an existing issue for this feature request?

  • I have searched the existing issues

Is your feature request related to a problem?

It is very frustrating to have to re-load these values each time I want to test new logical switches or alarms with the telemetry simulator. If I need to go back and edit something, it is again necessary to manually enter the values when returning to the simulator.

Describe the solution you'd like

A method to save the values I have entered, and then reload them later would be my choice. Use two buttons as shown in the attached picture.

Describe alternatives you've considered

The push buttons, circled in red, could be used to save/reload the values for all of the sensor values.

save and read telemetry values

Additional context

No response

@dwheeld dwheeld added the enhancement ✨ New feature or request label May 10, 2022
@pfeerick pfeerick added the companion Related to the companion software label May 11, 2022
@pfeerick pfeerick changed the title Please add a method to save and retrieve Companion Telemetry Simulator values Add a method to save and retrieve Companion Telemetry Simulator values May 11, 2022
@pfeerick
Copy link
Member

How about a method of being able to save it as a SD log file? The load functionality is already there, would just need the save ability?

@dwheeld
Copy link
Contributor Author

dwheeld commented May 11, 2022

I don't really understand. It isn't a log, it's just static values that are entered to test alarms, etc. A simple text file with the 31 or so values (for RxBt thru AccZ), is what I am referring to. The user clicks the save button and enters a name. for them to be saved under. Later, after leaving to edit alarms, they restart the telemetry simulator and read the values back in by clicking the load button and selecting the saved file.

QTextStream out, and in, is what I would use. I've attached telemetrysimu.cpp; .ui; and .h files modified to perform this. They go in companion\src\simulation.

telemetrysimu.zip

@pfeerick
Copy link
Member

And how do you cater for being able to save or load different sets of data?

@dwheeld
Copy link
Contributor Author

dwheeld commented May 11, 2022

Save the different sets of data under different file names, test1.txt, test2.txt, mydefaults.txt, etc.

@pfeerick
Copy link
Member

pfeerick commented May 11, 2022

Ah, sorry! I didn't realise you had implemented/considered being able to specify filename. In that case sounds good. I was only raising the log file functionality as all the load code is there already (no reinventing wheel required), and single row file would do just the same job + be self-descriptive ;)

@dwheeld
Copy link
Contributor Author

dwheeld commented May 11, 2022

I entered a pull request for this feature.

@dwheeld
Copy link
Contributor Author

dwheeld commented May 14, 2022

Is anything further expected from me on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants