[Serial Refactor] 2.7RC1 does not power TX16S AUX uarts for all protocols #1766

stronnag · 2022-03-30T11:56:46Z

On a TX16S, the AUX UARTS are not powered for all protocols

Protocol	Port Power
Telem Mirror	Yes
LUA	Yes
GPS	Yes
Telem In	Yes
CLI	No
Debug	No

Most recently tested with 5ffe757 2022-03-30

The AUX UARTS should be powered for all protocols (e.g. to use bluetooth dongle).

The text was updated successfully, but these errors were encountered:

pfeerick · 2022-03-30T12:19:45Z

I believe there will be a bluetooth option in the future also (thus basically removing the bluetooth compile option also as it will always be available). For debug I don't think power should be on, as it's intended for comms only, and for CLI I think it should be in the domain of CLI to turn the power on and off as desired (but I suspect that is not an option yet?).

stronnag · 2022-03-30T12:29:57Z

This has nothing to do with BT in the firmware, it's using an external BT dongle on a AUX port --- transparent serial.
So if I want to use a BT dongle for debug or CLI when I don't have a VCP cable available, you're telling me I can't.

raphaelcoeffic · 2022-03-30T12:37:20Z

@stronnag please check here:

edgetx/radio/src/serial.cpp

Lines 192 to 250 in 777b0a4

    
           static void serialSetupPort(int mode, etx_serial_init& params, bool& power_required) 
        
           { 
        
             switch (mode) { 
        
           #if defined(DEBUG) || defined(CLI) 
        
             case UART_MODE_DEBUG: 
        
             case UART_MODE_CLI: 
        
               params.baudrate = DEBUG_BAUDRATE; 
        
               break; 
        
           #endif 
        
           #if !defined(BOOT) 
        
             case UART_MODE_TELEMETRY_MIRROR: 
        
               // TODO: query telemetry baudrate / add setting for module 
        
               power_required = true; 
        
           #if defined(CROSSFIRE) 
        
               if (modelTelemetryProtocol() == PROTOCOL_TELEMETRY_CROSSFIRE) { 
        
                 params.baudrate = CROSSFIRE_TELEM_MIRROR_BAUDRATE; 
        
                 break; 
        
               } 
        
           #endif 
        
               params.baudrate = FRSKY_TELEM_MIRROR_BAUDRATE; 
        
               break; 
        
             case UART_MODE_TELEMETRY: 
        
               if (modelTelemetryProtocol() == PROTOCOL_TELEMETRY_FRSKY_D_SECONDARY) { 
        
                 params.baudrate = FRSKY_D_BAUDRATE; 
        
                 params.rx_enable = true; 
        
                 power_required = true; 
        
               } 
        
               break; 
        
             case UART_MODE_SBUS_TRAINER: 
        
               params.baudrate = SBUS_BAUDRATE; 
        
               params.word_length = ETX_WordLength_9; 
        
               params.parity = ETX_Parity_Even; 
        
               params.stop_bits = ETX_StopBits_Two; 
        
               params.rx_enable = true; 
        
               power_required = true; 
        
               break; 
        
           #if defined(LUA) 
        
             case UART_MODE_LUA: 
        
               params.baudrate = LUA_DEFAULT_BAUDRATE; 
        
               params.rx_enable = true; 
        
               power_required = true; 
        
               break; 
        
           #endif 
        
           #if defined(INTERNAL_GPS) 
        
             case UART_MODE_GPS: 
        
               params.baudrate = GPS_USART_BAUDRATE; 
        
               params.rx_enable = true; 
        
               power_required = true; 
        
               break; 
        
           #endif 
        
           #endif 
        
             } 
        
           }

And pay special attention to these lines:

power_required = true;

So the short answer is: it is by design, but it's not written in stone ;-)

stronnag · 2022-03-30T12:39:25Z

OK, so it is a feature that CLI and DEBUG are not available for such devices.

pfeerick · 2022-03-30T12:44:16Z

It's more that that is an unexpected use case. As Raphael said though, this is not set in stone. There is no reason an UI option couldn't be added to allow for the power to be toggled on or off in those modes if there is enough interest for such an addition.

rotorman · 2022-03-30T17:15:21Z

I can relate to the original post - if the serial port is not OFF, power should IMO be turned on, also for DEBUG or CLI.
An option in UI for the user to select this, would be even neater indeed.

raphaelcoeffic · 2022-04-01T04:37:57Z

@rotorman feel free to change it ;-)

rotorman · 2022-04-19T11:20:50Z

@stronnag would you care to test #1848

stronnag · 2022-04-19T11:22:49Z

@stronnag would you care to test #1848

Sure, I'll get back to you soonish. Thanks.

stronnag · 2022-04-19T15:45:20Z

On my TX16S

AUX ports are powered by command in the UI for all protocols
Don't seem to be able to set a working CLI on AUX1/2; other tested protocols (LUA, TelemMirror are OK)
CLI works on VCP

rotorman · 2022-04-19T15:54:44Z

Thank you for testing!

On my TX16S

* AUX ports are powered by command in the UI for all protocols

Meaning you can enable and disable power OK, as per checkbox?

* Don't seem to be able to set a working CLI on AUX1/2; other tested protocols (LUA, TelemMirror are OK)

This is likely unrelated to #1848
For TX16S need to use 400.000 baud 8N1, other radios use mostly 115.200 baud 8N1. Did you try with 400.000 baud?

stronnag · 2022-04-19T15:59:39Z

Thank you for testing!
On my TX16S
* AUX ports are powered by command in the UI for all protocols
Meaning you can enable and disable power OK, as per checkbox?

Yes

Don't seem to be able to set a working CLI on AUX1/2; other tested protocols (LUA, TelemMirror are OK)
This is likely unrelated to #1848 For TX16S need to use 400.000 baud 8N1, other radios use mostly 115.200 baud 8N1. Did you try with 400.000 baud?

No, my BT dongle is locked to 115200. I suspected that would be the problem. Let me try a USB-TTL adapter.

stronnag · 2022-04-19T17:11:47Z

Took a while to find an USB-TTL dongle that allows non-traditional baud rates (i.e. accepting 400000 rather than deciding that 460800 is close enough). No difference though, still no CLI on AUX; so for a different issue (at least if it's the same on MacOS and Windows).

Not withstanding your efforts, perhaps we should just close this again and accept that CLI is not a option for AUX (and the UI should enforce this limitation to avoid user frustration)?

rotorman · 2022-04-19T18:00:56Z

@stronnag Just tested #1848 with TX16S mkII, AUX1 set to CLI, SparkFun DEV-09717 hooked up to AUX1, hTerm connected with 400.000 baud 8N1. Works beautifully for me.
Are you sending CR+LF at the end? Type help accompanied by CR+LF? This is the output I get:

> help
beep [<frequency>] [<duration>]
ls <directory>
read <filename>
readsd <start sector> <sectors count> <read buffer size (sectors)>
testsd 
play <filename>
reboot [wdt]
set <what> <value>
serialpassthrough <port type> <port number>
help [<command>]
gps <baudrate>|$<command>|trace
>

stronnag · 2022-04-19T18:07:12Z

I have the CR+LF.
Works fine over the VCP, USB-TTL device works fine at 400000 with loopback. TX16 Mk1, Arch Linux (5.17), firmware compiled with gcc 11.20. I'll try an older compiler tomorrow.
However, this PR is fine, the power is working, before we too far off topic.

pfeerick · 2022-04-20T10:00:03Z

Or take the compiler out of the equation - try the github build of the PR? I find going back to / sticking with the GH builds when testing removes environmental variables if there are potential issues. 😀

https://github.com/EdgeTX/edgetx/suites/6172150719/artifacts/216510037
or
https://buddy.edgetx.org/#/dev/flash/pr?version=pr-1848%405682286173f09de936ac0640cb4f90a48a70a66e

stronnag · 2022-04-20T10:17:01Z

Thanks @pfeerick, the first option worked OK (CLI /AUX1 / 400000 baud). Interesting, inav firmware has some serial issues with 11.20 as well.
For my own satisfaction, I'll have to give 10.20 a go.

stronnag · 2022-04-20T10:33:00Z

and for the record, 10.20 works as well.
Thanks both.

stronnag closed this as completed Mar 30, 2022

rotorman reopened this Mar 30, 2022

rotorman mentioned this issue Apr 18, 2022

User controllable serial port power #1848

Merged

pfeerick linked a pull request Apr 20, 2022 that will close this issue

User controllable serial port power #1848

Merged

pfeerick added this to the 2.8 milestone Apr 20, 2022

pfeerick closed this as completed in #1848 Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serial Refactor] 2.7RC1 does not power TX16S AUX uarts for all protocols #1766

[Serial Refactor] 2.7RC1 does not power TX16S AUX uarts for all protocols #1766

stronnag commented Mar 30, 2022

pfeerick commented Mar 30, 2022 •

edited

Loading

stronnag commented Mar 30, 2022

raphaelcoeffic commented Mar 30, 2022 •

edited

Loading

stronnag commented Mar 30, 2022

pfeerick commented Mar 30, 2022 •

edited

Loading

rotorman commented Mar 30, 2022 •

edited

Loading

raphaelcoeffic commented Apr 1, 2022

rotorman commented Apr 19, 2022

stronnag commented Apr 19, 2022

stronnag commented Apr 19, 2022

rotorman commented Apr 19, 2022 •

edited

Loading

stronnag commented Apr 19, 2022

stronnag commented Apr 19, 2022

rotorman commented Apr 19, 2022 •

edited

Loading

stronnag commented Apr 19, 2022

pfeerick commented Apr 20, 2022

stronnag commented Apr 20, 2022 •

edited

Loading

stronnag commented Apr 20, 2022

[Serial Refactor] 2.7RC1 does not power TX16S AUX uarts for all protocols #1766

[Serial Refactor] 2.7RC1 does not power TX16S AUX uarts for all protocols #1766

Comments

stronnag commented Mar 30, 2022

pfeerick commented Mar 30, 2022 • edited Loading

stronnag commented Mar 30, 2022

raphaelcoeffic commented Mar 30, 2022 • edited Loading

stronnag commented Mar 30, 2022

pfeerick commented Mar 30, 2022 • edited Loading

rotorman commented Mar 30, 2022 • edited Loading

raphaelcoeffic commented Apr 1, 2022

rotorman commented Apr 19, 2022

stronnag commented Apr 19, 2022

stronnag commented Apr 19, 2022

rotorman commented Apr 19, 2022 • edited Loading

stronnag commented Apr 19, 2022

stronnag commented Apr 19, 2022

rotorman commented Apr 19, 2022 • edited Loading

stronnag commented Apr 19, 2022

pfeerick commented Apr 20, 2022

stronnag commented Apr 20, 2022 • edited Loading

stronnag commented Apr 20, 2022

pfeerick commented Mar 30, 2022 •

edited

Loading

raphaelcoeffic commented Mar 30, 2022 •

edited

Loading

pfeerick commented Mar 30, 2022 •

edited

Loading

rotorman commented Mar 30, 2022 •

edited

Loading

rotorman commented Apr 19, 2022 •

edited

Loading

rotorman commented Apr 19, 2022 •

edited

Loading

stronnag commented Apr 20, 2022 •

edited

Loading