From 400992b4fe8f4f22b1207354c2ed0bf068a866d7 Mon Sep 17 00:00:00 2001 From: David Jimenez Barrantes Date: Fri, 22 Mar 2024 10:45:09 -0600 Subject: [PATCH] [AA-1702] - Removes signalR. (#450) * Removes signalR. * Changes on project file web --- .../EdFi.Ods.AdminApp.Web/Hubs/EdfiOdsHub.cs | 27 ------------------- Application/EdFi.Ods.AdminApp.Web/Startup.cs | 5 +--- .../Views/Shared/_Layout.cshtml | 1 - .../CommonConfigurationInstaller.cs | 1 - Application/EdFi.Ods.AdminApp.Web/libman.json | 17 ------------ 5 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 Application/EdFi.Ods.AdminApp.Web/Hubs/EdfiOdsHub.cs delete mode 100644 Application/EdFi.Ods.AdminApp.Web/libman.json diff --git a/Application/EdFi.Ods.AdminApp.Web/Hubs/EdfiOdsHub.cs b/Application/EdFi.Ods.AdminApp.Web/Hubs/EdfiOdsHub.cs deleted file mode 100644 index 30a0d7b4d..000000000 --- a/Application/EdFi.Ods.AdminApp.Web/Hubs/EdfiOdsHub.cs +++ /dev/null @@ -1,27 +0,0 @@ -// SPDX-License-Identifier: Apache-2.0 -// Licensed to the Ed-Fi Alliance under one or more agreements. -// The Ed-Fi Alliance licenses this file to you under the Apache License, Version 2.0. -// See the LICENSE and NOTICES files in the project root for more information. - -using Microsoft.AspNetCore.Authorization; -using Microsoft.AspNetCore.SignalR; -using System.Threading.Tasks; - -namespace EdFi.Ods.AdminApp.Web.Hubs -{ - [Authorize] - public class EdfiOdsHub : Hub where T : class - { - protected string GroupName => typeof(T).ToString(); - - public async Task Subscribe() - { - await Groups.AddToGroupAsync(Context.ConnectionId, GroupName); - } - - public async Task Unsubscribe() - { - await Groups.RemoveFromGroupAsync(Context.ConnectionId, GroupName); - } - } -} diff --git a/Application/EdFi.Ods.AdminApp.Web/Startup.cs b/Application/EdFi.Ods.AdminApp.Web/Startup.cs index 9e70138c8..f82705f9a 100644 --- a/Application/EdFi.Ods.AdminApp.Web/Startup.cs +++ b/Application/EdFi.Ods.AdminApp.Web/Startup.cs @@ -18,7 +18,6 @@ using EdFi.Ods.AdminApp.Web._Installers; using EdFi.Ods.AdminApp.Web.ActionFilters; using EdFi.Ods.AdminApp.Web.Helpers; -using EdFi.Ods.AdminApp.Web.Hubs; using EdFi.Ods.AdminApp.Web.Infrastructure; using Microsoft.AspNetCore.Builder; using Microsoft.AspNetCore.Hosting; @@ -119,7 +118,7 @@ public void ConfigureServices(IServiceCollection services) pipeline.AddJavaScriptBundle("/bundles/bootstrap-multiselect.min.js", minifyJsSettings, "/Scripts/bootstrap-multiselect.js"); pipeline.AddJavaScriptBundle("/bundles/jquery-multiselect.min.js", minifyJsSettings, "/Scripts/jquery-multiselect.js"); pipeline.AddJavaScriptBundle("/bundles/modernizr.min.js", minifyJsSettings, "/Scripts/modernizr-2.8.3.js"); - pipeline.AddJavaScriptBundle("/bundles/site.min.js", minifyJsSettings, "/Scripts/site.js", "/Scripts/site-form-handlers.js", "/Scripts/signalr-progress.js"); + pipeline.AddJavaScriptBundle("/bundles/site.min.js", minifyJsSettings, "/Scripts/site.js", "/Scripts/site-form-handlers.js"); pipeline.AddJavaScriptBundle("/bundles/claimset.min.js", minifyJsSettings, "/Scripts/resource-editor.js"); pipeline.AddJavaScriptBundle("/bundles/authstrategy.min.js", minifyJsSettings, "/Scripts/auth-editor.js"); }); @@ -132,8 +131,6 @@ public void ConfigureServices(IServiceCollection services) services.Configure(Configuration.GetSection("IdentitySettings")); services.Configure(Configuration.GetSection("ConnectionStrings")); - services.AddSignalR(); - services.AddHttpClient(); services.Configure(options => diff --git a/Application/EdFi.Ods.AdminApp.Web/Views/Shared/_Layout.cshtml b/Application/EdFi.Ods.AdminApp.Web/Views/Shared/_Layout.cshtml index 9a5fefe62..010450800 100644 --- a/Application/EdFi.Ods.AdminApp.Web/Views/Shared/_Layout.cshtml +++ b/Application/EdFi.Ods.AdminApp.Web/Views/Shared/_Layout.cshtml @@ -34,7 +34,6 @@ See the LICENSE and NOTICES files in the project root for more information. - diff --git a/Application/EdFi.Ods.AdminApp.Web/_Installers/CommonConfigurationInstaller.cs b/Application/EdFi.Ods.AdminApp.Web/_Installers/CommonConfigurationInstaller.cs index 408977dbe..d0b505775 100644 --- a/Application/EdFi.Ods.AdminApp.Web/_Installers/CommonConfigurationInstaller.cs +++ b/Application/EdFi.Ods.AdminApp.Web/_Installers/CommonConfigurationInstaller.cs @@ -14,7 +14,6 @@ using EdFi.Ods.AdminApp.Management.Api; using EdFi.Ods.AdminApp.Management.Configuration.Application; using EdFi.Ods.AdminApp.Management.Helpers; -using EdFi.Ods.AdminApp.Web.Hubs; using EdFi.Ods.AdminApp.Web.Infrastructure; using EdFi.Common.Security; using EdFi.Ods.AdminApp.Management.ClaimSetEditor; diff --git a/Application/EdFi.Ods.AdminApp.Web/libman.json b/Application/EdFi.Ods.AdminApp.Web/libman.json deleted file mode 100644 index 6a5d2fcb8..000000000 --- a/Application/EdFi.Ods.AdminApp.Web/libman.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - "version": "1.0", - "defaultProvider": "cdnjs", - "libraries": [ - { - "provider": "unpkg", - "library": "@microsoft/signalr@latest", - "destination": "wwwroot/Scripts/signalr/", - "files": [ - "dist/browser/signalr.js", - "dist/browser/signalr.js.map", - "dist/browser/signalr.min.js", - "dist/browser/signalr.min.js.map" - ] - } - ] -} \ No newline at end of file