Multi component user mods #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
commented
May 17, 2017
| @@ -428,7 +430,10 @@ def _get_gridmaps_v2(self, component_grids): | |||
| if grid1_value != grid2_value and grid1_value != 'null' and grid2_value != 'null': | |||
| map_ = gridmaps[node.text] | |||
| if map_ == 'idmap': | |||
| logger.warning("Warning: missing non-idmap %s for %s, %s and %s %s " | |||
| if grid1_name == "ocn_grid" and grid1_value == atm_gridvalue: | |||
There was a problem hiding this comment.
This avoids the warning: Warning: missing non-idmap ROF2OCN_LIQ_RMAPNAME for ocn_grid, 0.9x1.25 and rof_grid r05. When the ocn grid matches the atm grid this file isn't used and there is no need for the warning.
| note = "This compset includes user_mods %s"%user_mods | ||
| append_status(note, "README.case", caseroot=self._caseroot) | ||
| logger.info(note) | ||
| comp = str(self.get_value("COMP_%s"%component_class)) |
There was a problem hiding this comment.
Each component can now specify it's own user mods.
|
Can you give an example of how this works in a create_newcase command? |
|
These are specified in the config_component.xml file for each component and not on the command line, there is no change in user interface. |
jgfouca
approved these changes
May 17, 2017
|
Waiting for @billsacks review. |
billsacks
approved these changes
May 17, 2017
mvertens
approved these changes
May 17, 2017
Merged
jedwards4b
added a commit
that referenced
this pull request
May 17, 2017
fixed bug in usermods Hot fix for duplicate user_mods call in PR #1551 Test suite: None Test baseline: None Test namelist changes: manual verification that user_mods is not called twice Test status: bit for bit Fixes User interface changes?: Code review: jedwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows multiple component user_mods. but gives primary component precedent.
Fixes warning issues for ocn grid non-idmap error if ocn is DOCN
Rearrange tests in scripts_regression_tests to avoid conflict between tests.
Test suite: scripts_regression_tests.py hand tests with F2000_DEV and contrived user_mods
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?:
Code review: