Give users more info and control over key run commands #1359
Conversation
| @@ -299,16 +299,23 @@ def submit_jobs(self, case, no_batch=False, job=None, batch_args=None): | |||
| if prereq is None or job == firstjob: | |||
| prereq = True | |||
| else: | |||
| if dry_run: | |||
There was a problem hiding this comment.
Why not just add dry_run to the condition on line 299?
There was a problem hiding this comment.
dry_run is the only case where we want to fake-out the BUILD_COMPLETE prereq.
There was a problem hiding this comment.
Oh, I see what you mean. We want to preserve the other prereqs besides the BUILD_COMPLETE one so that we get an accurate list of which jobs will be run.
|
@jedwards4b ever since the change to python, users have been asking for direct control over the submit and mpirun commands. Apparently, it was part of their workflow to open the shell scripts generated by CIME2 and modify these commands directly. The override XML values allow them to do this again. |
|
@rljacob Still waiting for your action on this one... |
|
@rljacob What is the hold up on this one? |
|
Finding time to try it out. Doing it today. |
|
I tried building an X case with this branch on blues "./create_newcase -case Xcase2 -compset X -res f19_g16" and the "preview_run" command was not in my caseroot even after running case.setup and case.build. |
| @@ -2602,6 +2602,15 @@ | |||
| <desc>The machine wallclock setting. Default determined in config_machines.xml can be overwritten by testing</desc> | |||
| </entry> | |||
|
|
|||
| <entry id="BATCH_COMMAND"> | |||
There was a problem hiding this comment.
Please rename to BATCH_COMMAND_FLAGS
|
Make sure preview_run shows up in caseroot so people see it. Like preview_namelist. |
Done |
…ools * origin/master: (110 commits) Fixed Some Tabulation Removed Tabs from create_newcase Change PET test to fit on desktops remove broken pfunit directory nag needs a lib pointer TOTAL_CORES needs to be set before xml files are locked Fix mistake PIO settings need to happen before init_derived_attributes Order of operations was not correct Re-initialize key case values upon case.setup Double nodes instead of halving tasks PET must halve TASKS when doubling THRDS Fix big mistake in scripts_regression_tests handle case when executable is none (scripts_regression_tests) Fix minor bug in test_scheduler Minor changes to xmlchange Print time built per model Add input-dir to create_newcase More changes for testreport from code review. Add testreporter.template. Fix comment in test_reporter.py ...
Awesome. |
* Use proper syntax to refer to OMP_NUM_THREADS in config_machines.xml.
Must use ENV syntax.
* Move setting of OMP_NUM_THREADS earlier so it will be captured
by provenance saving.
* Avoid hyper-threading on Edison.
Fixes #1355
[BFB]
Adds new tool 'preview_run' to give users a preview of what their batch submissions and mpirun will look like.
Adds new override XML variables so users can exercise direct control over there batch and mpirun cmds if they want (advanced users only).
Test suite: scripts_regression_tests --fast
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1263
User interface changes?: Signficant: new preview_run tool and new XML variables
Code review: Many