-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cime5.2 changes from acme 03292017 #1287
Merged
Merged
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
922150b
added 173 and 375 node options for Edison
PeterCaldwell 45a5327
made 114 node hyperthreaded the default for ne30 F-compset
PeterCaldwell 3320f78
add full performance data and provenance capture support for Anvil
db66b2e
fix calculation of TOT Run Time in get_timing.py
2959855
Fixes support for LANL_IC machine grizzly
vanroekel b7fa4de
Fixes max_tasks_per node
vanroekel b237c07
Add homme.log to TestStatus.log for HOMME test
jgfouca 446a939
Add grid configure for T42 for SCM
bogensch ff3e6d6
Removed 114 node F-compset layout that failed SMS-D test
PeterCaldwell b6da43f
Update support for LANL IC machine wolf.
jonbob 80883c5
Fix shortname for ne30np4_oEC60to30v3 grid
jonbob 02b1ed0
refactor syslog.anvil to decrease number of files created
57af7eb
Merge branch 'vanroekel/machines/LANL_update' (PR #1260)
jonbob 57b8f12
Added git to modules for cori
7acca9b
Updates the support for LBL Lawrencium machines
ef5e0d3
Changes to use module craype-mic-knl to build/run on KNL nodes of Cori.
ndkeen ad10e15
Add default PE configurations for ne30 A_WCYCL cases
amametjanov 9fbddba
Add IBM compiler macro
amametjanov dcef6a4
Merge branch 'worleyph/machines/Anvil_perf_data_capture' (PR #1248)
amametjanov c66197d
Merge branch 'azamat/mira/add-cpribm-macro' (PR #1277)
amametjanov 5fa630f
Fixes support for LBL Lawrencium machines
9808efa
Merge branch 'bishtgautam/machinefiles/update-support-for-lbl-machine…
1879505
Fixing Module issues on titan
mrnorman 1246f3b
Merge branch 'bogensch/atm/EUL_SCM_cime' (PR #1253)
singhbalwinder d003d7a
Pat's config file that fixed runtime issues.
mrnorman de96f17
Merge branch 'PeterCaldwell/cime/pe_layout1' (PR #1241)
ndkeen e554702
Merge branch 'ndk/machinefiles/cori-knl-craype-mic-knl' (PR #1270)
ndkeen a28d68a
Merge cime5.2.0 into rljacob/cime/uptocime5.2.0
rljacob 6bbed68
Restore ACME orbit calculation
rljacob 17ffcd4
Trying to get acme_developer to work
jgfouca a03224b
More fixes to 5.2
jgfouca fb9ae61
More fixes to get SMS_Ly3.1x1_smallvilleIA.ICLM45CNCROP.melvin_gnu.fo…
jgfouca dbdf92c
Need uppercase boolean strings
jgfouca cd9b6e0
Fix a couple places that were using the outdated 'CCSM_COMPSET' entry
jgfouca 1277174
Progress getting MPAS to work with 5.2
jgfouca 98579da
Change ROF2OCN_RMAPNAME to LIQ and ICE RMAPNAME
rljacob 91a6542
Get HOMME test working again
rljacob d6bc5f9
Fix whitespace error in ACME Makefile
jgfouca 8758cab
Disable sharing of sharedlib in ACME
jgfouca 2ddfe69
Update configs after conflict resolution
rljacob 82493c9
Add ARCHIVE_SPEC_FILE entry
rljacob 1c8fa70
Restore OCN_NCPL for A cases
rljacob ddde3a9
Update main config_archive
rljacob a823c93
Add more SLND-based settings for A-cases.
rljacob 625c073
ACME must do a namelist-gen at case.setup
jgfouca fc9e623
Updated branch to newest master
9918a7a
Hotfix to chmod operation in hist_utils.
jgfouca c97f6e0
Merge branch 'mrnorman/titan-machine/fix-mpich-bug' into master (PR #…
jgfouca 33ea2c5
Fix for wallclock time specifications >24H
mfdeakin-sandia 131a8fc
Fix pylint errors
mfdeakin-sandia acf18db
Improvements to the format_time utility function
mfdeakin-sandia 87d1137
Fix typo in doctest
mfdeakin-sandia 7e6a766
Fix for blues submit.
jgfouca 722190a
Merge branch 'jgfouca/cime/fix_blues_submit' into master (PR #1319)
jgfouca 61aa2df
Merge branch 'mfdeakin-sandia/cime_5_2/time_processor' into master (P…
jgfouca 30c6e56
Numerous titan fixes.
jgfouca 78c0c58
Increase jobmax on redsky
jgfouca 31008cb
Merge branch 'jgfouca/cime/increase_redsky_queue' into master (PR #1322)
jgfouca d7397d9
For cori-knl, adjust modules to prevent module errors in cime.
ndkeen 46bb8b7
Update number of nodes passed to Mira qsub
amametjanov 2cb4c56
Merge branch 'azamat/mira/pe-calc-update' (PR #1325)
amametjanov 789127a
Default large PEs for ne30 A_WCYCL-compset
amametjanov 26216da
Add ne120 compsetis based on AV1C-04P2
wlin7 3c538f3
Fix aprun command construction
jgfouca 8fd3f7f
Change ACME BFBFLAG default to TRUE
rljacob 02ad4e1
Fixes to further improve interaction between HOMME and CIME
jgfouca e5b31db
Fixing walltime for titan debug queue
jayeshkrishna 383cfbd
Merge branch 'wlin/atm/v1ac-h01' (PR ##1332)
singhbalwinder f8b6c4f
Re-introduce task_maker algorithm to compute aprun
jgfouca 6dca409
Merge branch 'rljacob/cime/bfbflagtrue' (PR #1335)
rljacob 4b6d0e5
Add unit test
jgfouca e395279
Add test for intel compiler
jgfouca c7e3abf
Remove outdated comment
jgfouca 8fa0bee
Don't define PNETCDF_PATH for mpi-serial+anvil
jayeshkrishna 616ef9c
Merge branch 'jayeshkrishna/fix_anvil_mpi_serial' (PR #1341)
jayeshkrishna 3f38b20
Fix spelling of NTHRDS
jgfouca f378bed
Make netcdfroot less hardcoded for titan
jgfouca 9794385
Fix macro maker
jgfouca fe4224a
update modules to support netcdf4 files on Titan
f15461d
Fix type in melvin config change
jgfouca 9df7736
Merge branch ACME-Climate/worleyph/cime/get_timing_fix (PR #1249)
ndkeen f5898c9
Merge branch 'erichlf/cime/NCPL' (PR #1223)
rljacob cca7b32
Merge branch 'jgfouca/cime/fixes_for_titan' (PR #1321)
rljacob 6b8f26f
Restore optimized num nodes.
jgfouca 0b4c279
Merge ags./split-03292017 into ags./cime52-with-acmesplit-03292017
agsalin 30609e6
Fix more conflicts
agsalin 2a330ef
Merge a-/cime52-with-acmesplit-03292017 to a-/merge-from-acme-03292017
agsalin bfcad30
Fix merge issues -- caught by testing
agsalin d8b691a
Final fixes for scritps tests to pass
agsalin c63a4e1
Fix build.py merge issues
agsalin d80c428
Make optimized nodes related to aprun, not titan
jgfouca 03001c8
Fix inverted if statement
jgfouca 9e10abe
Merge branch 'master' into agsalin/merge-from-acme-03292017
jgfouca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,9 +123,10 @@ def _initialize_derived_attributes(self): | |
These are derived variables which can be used in the config_* files | ||
for variable substitution using the {{ var }} syntax | ||
""" | ||
env_mach_pes = self.get_env("mach_pes") | ||
comp_classes = self.get_values("COMP_CLASSES") | ||
pes_per_node = self.get_value("PES_PER_NODE") | ||
env_mach_pes = self.get_env("mach_pes") | ||
env_mach_spec = self.get_env('mach_specific') | ||
comp_classes = self.get_values("COMP_CLASSES") | ||
pes_per_node = self.get_value("PES_PER_NODE") | ||
|
||
self.total_tasks = env_mach_pes.get_total_tasks(comp_classes) | ||
self.thread_count = env_mach_pes.get_max_thread_count(comp_classes) | ||
|
@@ -139,7 +140,14 @@ def _initialize_derived_attributes(self): | |
threads_per_core = 1 if (threads_per_node <= pes_per_node) else smt_factor | ||
self.cores_per_task = self.thread_count / threads_per_core | ||
|
||
if self.get_value("MACH") == "titan": | ||
mpi_attribs = { | ||
"compiler" : self.get_value("COMPILER"), | ||
"mpilib" : self.get_value("MPILIB"), | ||
"threaded" : get_build_threaded(self) | ||
} | ||
|
||
executable = env_mach_spec.get_mpirun(self, mpi_attribs, job="case.run", exe_only=True)[0] | ||
if executable == "aprun": | ||
self.num_nodes = get_aprun_cmd_for_case(self, "acme.exe")[1] | ||
else: | ||
self.num_nodes = env_mach_pes.get_total_nodes(self.total_tasks, self.thread_count) | ||
|
@@ -1068,7 +1076,9 @@ def get_mpirun_cmd(self, job="case.run"): | |
|
||
# special case for aprun | ||
if executable == "aprun": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use this instead of test for titan above at line 142? |
||
return get_aprun_cmd_for_case(self, run_exe)[0] + " " + run_misc_suffix | ||
aprun_cmd, num_nodes = get_aprun_cmd_for_case(self, run_exe) | ||
expect(num_nodes == self.num_nodes, "Not using optimized num nodes") | ||
return aprun_cmd + " " + run_misc_suffix | ||
else: | ||
mpi_arg_string = " ".join(args.values()) | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic looks wrong - if exe_only is False then args is not assigned either? I think you mean
if not exe_only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes