need to set RTM to NULL in both cases in order to have this work with… #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… upcoming pythonization of rtm and mosart buildnml
jedwards4b
approved these changes
Mar 14, 2017
jedwards4b
added a commit
to jedwards4b/cime
that referenced
this pull request
Dec 8, 2017
fbc3584 Merge pull request ESMCI#1239 from NCAR/dontuse_nc_max 63dee3d Merge pull request ESMCI#1240 from NCAR/limitto2GiB 64f2492 limit to 2GiB due to romio bug 29aee05 dont use NC_MAX values d831ad3 Merge pull request ESMCI#1231 from mgduda/mpi_type_fix e996bdb Merge pull request ESMCI#1222 from NCAR/ejh_autoconf_logging 426af22 Partial fix for incorrect type of 'mpi_type' in pioc_support.c 7eb724f added enable-logging option to autotools build git-subtree-dir: src/externals/pio2 git-subtree-split: fbc3584
jedwards4b
added a commit
to jedwards4b/cime
that referenced
this pull request
Dec 12, 2017
fbc3584 Merge pull request ESMCI#1239 from NCAR/dontuse_nc_max 63dee3d Merge pull request ESMCI#1240 from NCAR/limitto2GiB 64f2492 limit to 2GiB due to romio bug 29aee05 dont use NC_MAX values d831ad3 Merge pull request ESMCI#1231 from mgduda/mpi_type_fix e996bdb Merge pull request ESMCI#1222 from NCAR/ejh_autoconf_logging 426af22 Partial fix for incorrect type of 'mpi_type' in pioc_support.c 7eb724f added enable-logging option to autotools build git-subtree-dir: src/externals/pio2 git-subtree-split: fbc3584
jedwards4b
added a commit
to jedwards4b/cime
that referenced
this pull request
Dec 12, 2017
0f241db response to comments 1007a7a cannot predetermin ndims here 99ef07d Merge pull request ESMCI#1241 from NCAR/free_new_allocs 29ed162 free recently allocated vars fbc3584 Merge pull request ESMCI#1239 from NCAR/dontuse_nc_max 63dee3d Merge pull request ESMCI#1240 from NCAR/limitto2GiB 64f2492 limit to 2GiB due to romio bug 29aee05 dont use NC_MAX values d831ad3 Merge pull request ESMCI#1231 from mgduda/mpi_type_fix e996bdb Merge pull request ESMCI#1222 from NCAR/ejh_autoconf_logging 426af22 Partial fix for incorrect type of 'mpi_type' in pioc_support.c 7eb724f added enable-logging option to autotools build git-subtree-dir: src/externals/pio2 git-subtree-split: 0f241db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix needed for upcoming pythonization of rtm and mosart buildnml
RTM is being used incorrectly in the ssp test - and this fix ensures that both phases of NULL.
This enables the new RTM and MOSART pythonized buildnml scripts to pass the SSP test.
Only ran the ran SSP_Ld10.f19_g16.I1850CLM45BGC.yellowstone_pgi.clm-default test. Verified that the test passed and the only differences with respect to the baseline were the RTM fields.
Test suite: None
Test baseline:
Test namelist changes:
Test status: bit for bit - except for any test using ssp.py
Fixes
User interface changes?: None
Code review: