Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab characters should be removed from strings in streams files #862

Closed
billsacks opened this issue Nov 30, 2016 · 5 comments
Closed

Tab characters should be removed from strings in streams files #862

billsacks opened this issue Nov 30, 2016 · 5 comments
Assignees
@mvertens
Labels
CRITICAL
Milestone
CIMErelease

Comments

@billsacks
Copy link
Member

Issue by quantheory
Wednesday Jul 29, 2015 at 22:27 GMT
Originally opened as CESM-Development#72

From a Bugzilla issue from Bill Sacks:

A user ran into a problem when editing a streams file (dlnd.streams.txt.sno.cplhist): there were some tab characters in the file both before and after some strings. It looks like these tab characters are not stripped from the strings (e.g., using shr_string_leftAlign). This led to an error that looked like this in the lnd log file:

(shr_sys_abort) ERROR: (shr_stream_getCalendar)  ERROR: nf90_open file      /glade/scratch/gailg        /           IG_spinup_smb4.cpl.hs2x.0067.4avgmax.nc

Since tabbing is a natural thing to do when editing text files, it seems it would be good to extend the shr_string utilities to strip tabs as well as spaces.
@billsacks
Copy link
Member Author

Comment by billsacks
Wednesday Apr 13, 2016 at 15:14 GMT

This just caused some scientists a few days of lost time... we should try to fix it for the cesm2 release.

@billsacks billsacks added this to the cesm2 milestone Nov 30, 2016
@billsacks
Copy link
Member Author

Comment by mvertens
Wednesday Apr 13, 2016 at 18:42 GMT

This should be fixed in the next CIME tag that gets brought in.

@billsacks
Copy link
Member Author

Comment by mvertens
Wednesday Apr 13, 2016 at 18:45 GMT

Tony, if you could take this one on, given your expertise in the shr_stream code, that would be great.

@billsacks
Copy link
Member Author

Comment by jedwards4b
Wednesday Nov 30, 2016 at 20:20 GMT

@apcraig has this been addressed? If not please reopen in esmci.

@billsacks billsacks mentioned this issue Nov 30, 2016
Closed
rljacob added a commit that referenced this issue Feb 8, 2017
@rljacob
Merge branch 'bishtgautam/lnd/buildnml' (PR #862)
b002b2b 
clm.buildnml scripts now sends -mask to
build-namelist script. This generates land namelist
with correct finidat value when there are multiple
land-ocean masks (e.g. gx1v6 and oEC60to30) for a single
land grid (e.g. ne30np4).

This change requires that all new land-ocean masks must
be added in
components/clm/bld/namelist_files/namelist_definition_clm4_5.xml

Fixes #861
[NML]
@billsacks
Copy link
Member Author

I haven't tested to verify this is still a problem, but it looks like shr_string_leftAlign hasn't changed, so I assume this is still an issue.

See https://software.intel.com/en-us/forums/archived-visual-fortran-read-only/topic/314044 for some possible implementations that address this.

@mvertens mvertens self-assigned this May 13, 2017
@mvertens mvertens mentioned this issue May 14, 2017
Merged
jedwards4b added a commit that referenced this issue May 15, 2017
@jedwards4b
Merge pull request #1531 from ESMCI/mvertens/remove_stream_tabs
5894c4d 
add ability to remove tabs in shr_string_lalign
Removal of tabs from strings in stream files

Test suite: scripts_regression_tests
also manual verification that if tabs were introduced in a streams text file
(e.g. datm.streams.txt.CORE2_NYF.GISS)
then the resulting data model behaved correctly
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #862
User interface changes?: None
Code review:sacks, edwards,
@ghost ghost removed the in progress label May 15, 2017
@billsacks billsacks mentioned this issue May 15, 2017
Closed
@mvertens mvertens mentioned this issue May 16, 2017
Merged
billsacks added a commit that referenced this issue May 17, 2017
@billsacks
Merge pull request #1547 from ESMCI/mvertens/convert_stream_tabs
7355f9d 
Convert all tabs to spaces in data model stream txt files

Test suite: scripts_regression_tests
also manual verification that if tabs were introduced in a streams text file
(e.g. datm.streams.txt.CORE2_NYF.GISS)
then the resulting data model behaved correctly
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #862
User interface changes?: None
Code review: billsacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvertens mvertens

Labels
CRITICAL
Projects
None yet
Milestone
CIMErelease
Development

No branches or pull requests
2 participants
@billsacks @mvertens