Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up python in unit_testing #1424

Closed
rljacob opened this issue Apr 26, 2017 · 4 comments
Closed

Clean up python in unit_testing #1424

rljacob opened this issue Apr 26, 2017 · 4 comments
Assignees
@billsacks

Comments

@rljacob
Copy link
Member

rljacob commented Apr 26, 2017

Clean up code in unit_testing/python
@rljacob rljacob added the ready label Apr 26, 2017
@billsacks
Copy link
Member

(Much of this is now dead code and should be removed.)

@rljacob
Copy link
Member Author

rljacob commented Apr 26, 2017

Recommend do this after #1423 is closed.

@billsacks billsacks assigned billsacks and unassigned jedwards4b Apr 26, 2017
@billsacks
Copy link
Member

I'll take this. For some reason code_checker is reporting problems with the stuff in this directory (now that I have moved it under scripts/fortran_unit_testing) that didn't seem to be causing problems before... so I'll clean this up as part of addressing #1423 .

@jedwards4b
Copy link
Contributor

scripts_regression_tests has a list of directories for which code_checker will not be run, the old unit_tests directory is in that list.

@billsacks billsacks mentioned this issue Apr 26, 2017
Merged
@ghost ghost added in progress and removed ready labels Apr 26, 2017
@ghost ghost removed the in progress label Apr 27, 2017
jedwards4b added a commit that referenced this issue Apr 27, 2017
@jedwards4b
Merge pull request #1428 from billsacks/move_unit_tests
9c5b1aa 
Move unit tests to scripts/fortran_unit_testing
Moves unit testing infrastructure from tools/unit_testing to
scripts/fortran_unit_testing.

Rationale: tools are supposed to be optional tools, whereas the Fortran
unit tests are a more required part of the testing workflow.

Also cleans up python in fortran_unit_testing directory:

Remove dead code (which has been replaced by use of the standard CIME
utilities)

Clean up pylint problems

Also updates some documentation

Test suite: scripts_regression_tests on yellowstone
Test baseline: n/a
Test namelist changes: n/a
Test status: bit for bit

Fixes #1423
Fixes #1424

User interface changes?: Moves run_tests.py to scripts/fortran_unit_testing

Code review: jedwards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rljacob @jedwards4b @billsacks