Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nobypass test fails on Derecho #79

Closed
ekluzek opened this issue Jan 9, 2024 · 1 comment · Fixed by #70
Closed

nobypass test fails on Derecho #79

ekluzek opened this issue Jan 9, 2024 · 1 comment · Fixed by #70
Assignees
Labels

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Jan 9, 2024

The test

ERI_D.f10_f10_mg37.I1850Clm50Sp.derecho_intel.mosart-nobypass

fails to run on Derecho in mosart1_0_48 because it times out after the overly generous 3:40. I think the problem may be because there is so much output reporting on negative runoff.

@ekluzek ekluzek added the bug label Jan 9, 2024
@ekluzek ekluzek self-assigned this Jan 9, 2024
@ekluzek
Copy link
Contributor Author

ekluzek commented Jan 10, 2024

As suspected when I remove the output about negative flow the test works fine:

diff --git a/src/riverroute/MOSART_physics_mod.F90 b/src/riverroute/MOSART_physics_mod.F90
index a2d327f..66ea867 100644
--- a/src/riverroute/MOSART_physics_mod.F90
+++ b/src/riverroute/MOSART_physics_mod.F90
@@ -324,10 +324,10 @@ subroutine Routing_KW(iunit, nt, theDeltaT)
 
     if((TRunoff%wr(iunit,nt)/theDeltaT &
          + TRunoff%dwr(iunit,nt)) < -TINYVALUE) then
-       write(iulog,*) 'mosart: ERROR main channel going negative: ', iunit, nt 
-       write(iulog,*) theDeltaT, TRunoff%wr(iunit,nt), &
-            TRunoff%wr(iunit,nt)/theDeltaT, TRunoff%dwr(iunit,nt), temp_gwl
-       write(iulog,*) ' '
+       !write(iulog,*) 'mosart: ERROR main channel going negative: ', iunit, nt 
+       !write(iulog,*) theDeltaT, TRunoff%wr(iunit,nt), &
+       !     TRunoff%wr(iunit,nt)/theDeltaT, TRunoff%dwr(iunit,nt), temp_gwl
+       !write(iulog,*) ' '
        !       call shr_sys_abort('mosart: ERROR main channel going negative')
     endif

@ekluzek ekluzek closed this as completed in fcc37a7 Feb 2, 2024
slevis-lmwg added a commit to slevis-lmwg/MOSART that referenced this issue Nov 8, 2024
PR ESCOMP#70 add more tests especially on izumi and merge other PRs

Resolves ESCOMP#68
Resolves ESCOMP#79
Resolves ESCOMP#61
Resolves ESCOMP#91
Resolves ESCOMP#103
Resolves ESCOMP#104
Resolves ESCOMP#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant