Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MOSART tests to all be Clm60? #107

Closed
ekluzek opened this issue Oct 31, 2024 · 1 comment · Fixed by #70
Closed

Change MOSART tests to all be Clm60? #107

ekluzek opened this issue Oct 31, 2024 · 1 comment · Fixed by #70
Assignees
@slevis-lmwg
Labels
code cleanup enhancement

Comments

@ekluzek
Copy link
Contributor

ekluzek commented Oct 31, 2024

The MOSART tests are currently almost all Clm50, with the CESM3.0 release and Clm60 being available I think they should be updated to all be Clm60. Testing for different CLM versions likely should just be part of the CLM testing, and MOSART tests should just be using the latest CLM physics option.

@slevis-lmwg do you have an opinion on this?
@ekluzek ekluzek mentioned this issue Oct 31, 2024
Merged
@slevis-lmwg
Copy link
Contributor

That sounds reasonable to me.

@slevis-lmwg slevis-lmwg self-assigned this Oct 31, 2024
slevis-lmwg added a commit to slevis-lmwg/MOSART that referenced this issue Nov 8, 2024
@slevis-lmwg
Merge tag 'mosart1.1.03' into time_is_mid_of_bounds_iss52
6e06d77 
PR ESCOMP#70 add more tests especially on izumi and merge other PRs

Resolves ESCOMP#68
Resolves ESCOMP#79
Resolves ESCOMP#61
Resolves ESCOMP#91
Resolves ESCOMP#103
Resolves ESCOMP#104
Resolves ESCOMP#107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slevis-lmwg slevis-lmwg

Labels
code cleanup enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more tests and merge in some other PR's ekluzek/MOSART
2 participants
@ekluzek @slevis-lmwg