Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve anomaly forcings for ISSP cases #2686
base: master
Are you sure you want to change the base?
Fix and improve anomaly forcings for ISSP cases #2686
Changes from all commits
208c594
8d628f2
702477d
f59d045
662e536
8df08ff
1416363
4b96267
825fbb6
496c154
0a8df10
634cfce
42b7575
567fcad
597a4de
c4ec313
49382ee
728257b
4da4587
51a8e1b
1644c61
5aae2a6
a2fc1c1
f514ed8
da2f4e8
8cb5854
01967bf
124027b
28ecb3f
865858f
741dc33
546dbca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe we add this one to aux_clm as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need to do this. And you are asking for the ctsm5.2 dataset, which isn't going to work.
So I think this testmod should be removed. But, I might be missing something.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question.
It could be worth trying it without it to make sure it is required for all the fields. Setting it for some fields was required in the past, but may not be anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these two scripts about? Something temporary needed while the PR is created and then removed at the last moment?
If so that's an interesting strategy that sounds useful.