was not working when atm and lnd did not share all tasks

[jedwards4b]

Description of changes

Replace shr_mpi_bcast with ESMF_VMBroadcast. Was not working when lndroot .ne. atmroot.

Specific notes

This change affects cesm only.

Contributors other than yourself, if any: Mariana

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? bfb

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

• (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
  • machines:
  • details (e.g. failed tests):
• (recommended) CESM testlist_drv.xml
  • machines and compilers: cheyenne, intel
  • details (e.g. failed tests):
• (optional) CESM prealpha test
  • machines and compilers
  • details (e.g. failed tests):
• (other) please described in detail
  • machines and compilers Testnames: ['ERS.ne30_g17.B1850.cheyenne_intel', 'ERS_Ln9.f19_f19_mg17.FHIST.cheyenne_intel.cam-outfrq9s']
  • details (e.g. failed tests): ALL PASS

Testing performed if application target is UFS-coupled:

• (recommended) UFS-coupled testing
  • description:
  • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

• (recommended) UFS-HAFS testing
  • description:
  • details (e.g. failed tests):

Hashes used for testing:

• CESM:
  • repository to check out: https://github.com/ESCOMP/CESM.git
  • branch/hash: alpha10b candidate
• UFS-coupled, then umbrella repostiory to check out and associated hash:
  • repository to check out:
  • branch/hash:
• UFS-HAFS, then umbrella repostiory to check out and associated hash:
  • repository to check out:
  • branch/hash:

[mvertens]

@jedwards4b before your merge this PR - please document your testing and a more comprehensive documentation of the problem so that we can remember exactly what this was. Its important to point out that B cases need to be done when any change to cmeps is done - particularly in the share code.

[jedwards4b]

@mvertens I ran the cmeps test suite and got the following fails:

  ERS_Ly3_Vnuopc.f09_g17_gl4.T1850Gg.cheyenne_intel (Overall: FAIL) details:
    FAIL ERS_Ly3_Vnuopc.f09_g17_gl4.T1850Gg.cheyenne_intel RUN time=7
  ERS_Vnuopc_Ld5.T62_t061.CMOM.cheyenne_intel (Overall: FAIL) details:
    FAIL ERS_Vnuopc_Ld5.T62_t061.CMOM.cheyenne_intel RUN time=309
  ERS_Vnuopc_Ld5.T62_t061.GMOM.cheyenne_intel (Overall: FAIL) details:
    FAIL ERS_Vnuopc_Ld5.T62_t061.GMOM.cheyenne_intel COMPARE_base_rest
  SMS_D_Ly1_Vnuopc.f09_g17_gl4.T1850Gg.cheyenne_intel (Overall: FAIL) details:
    FAIL SMS_D_Ly1_Vnuopc.f09_g17_gl4.T1850Gg.cheyenne_intel RUN time=7

Looking into them this morning.

[jedwards4b]

The latest commit fixed the T1850Gg tests, the other two reran and passed.