Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hard-wiring of wavice_coupling config (applies only to CESM) #312

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Oct 6, 2022

Description of changes

fix hard-wiring of wavice_coupling config (applies only to CESM)

Specific notes

This PR has a simple fix (changes nmlgen.set_value to nmlgen.add_default) in order to permit the
setting of wavice_coupling to be changed in user_nl_cpl.

Contributors other than yourself, if any: None

CMEPS Issues Fixed:

Are changes expected to change answers? bfb

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed

Testing performed if application target is CESM:
Verified that wavice_coupling could be changed in nuopc.runconfig my changing user_nl_cpl.

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@mvertens mvertens requested a review from jedwards4b October 6, 2022 20:21
@mvertens mvertens merged commit ce1bb64 into ESCOMP:master Oct 6, 2022
@mvertens mvertens deleted the feature/fix_wavice branch June 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants