-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring external land component support to UFS #310
Conversation
@mvertens @DeniseWorthen i am currently testing with CESM. I'll update you about it. |
all tests are passed without any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in reviewing. I don't see any issues w/ this PR.
@DeniseWorthen Thanks. I think we will merge this first and update CMEPS in UFS side later with your UFS level PR. Right? |
Yes, my original thought was that your UFS PR will need new baselines for the added tests. But if we did just a CMEPS PR, we would be able to get that one out of the way first, since it will be able to be combined w/ another non-baseline change PR. But at this point there isn't much in the queue. So I'm not sure it is worth it to do them separately. |
@DeniseWorthen Then, let's merge this and you just update CMEPS in UFS side. I think it would be easier. @mvertens could you review this PR. Then, we could merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks fine. @uturuncoglu - can you please run one fully coupled CESM case to see that everything runs before merging. I will not have time to do that today.
@mvertens I have already run CESM testlist_drv.xml test with cesm2_3_beta09 and they were okay. If you want me to test again. I could do it. |
@uturuncoglu - thanks! I should have checked. Please go ahead and merge. |
Description of changes
This PR aims to extend nems application to support external land component. Along with these changes, the UFS model will be able to support following RTs:
datm_cdeps_lnd_gswp3
: 1 day run with CDEPS GSWP3 datasetdatm_cdeps_lnd_gswp3_rst
: restart run with CDEPS GSWP3 datasetcontrol_p8_atmlnd_sbs
: side-by-side test with active atmosphere, uses same configuration withcontrol_p8
and the interaction with FV3 is uni-directional to allow comparing the results coming from FV3/CCPP/NOAHMP with external NOAHMP componentSpecific notes
Contributors other than yourself, if any: No
CMEPS Issues Fixed (include github issue #):
A minor issue related with the land component which does not provide
cpl_scalars
to mediator is fixed.Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: