Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Henrys Law coefficients from file #303

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Conversation

fvitt
Copy link
Collaborator

@fvitt fvitt commented Jun 1, 2022

Description of changes

This moves the hard-wired data from seq_drydep_mod to an input file that can be easily replaced to provide flexibility.

Specific notes

This PR needs to be coordinated with
ESCOMP/CAM#602

See relevant discussion in:
ESCOMP/CESM_share#8

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
ESCOMP/CESM_share#8

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
bfb

Any User Interface Changes (namelist or namelist defaults changes)?
Added dep_data_file (in drv_flds_in) for the path of the input data file containing Henrys Law coefficients

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines: cheyenne, izumi
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • aux_cam tests
    • machines and compilers: cheyenne-intel, izumi-gnu, izumi-nag
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

fvitt added 4 commits November 3, 2021 18:50
        modified:   cesm/nuopc_cap_share/seq_drydep_mod.F90
        new file:   cesm/nuopc_cap_share/shr_drydep_mod.F90
        modified:   cesm/nuopc_cap_share/shr_drydep_mod.F90
@jedwards4b
Copy link
Collaborator

@fvitt this change was never tested with a B case or with a case in which atm ntasks were not the same as lnd ntasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants