-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CCPP host model under CMEPS and updates for UFS exchange grid capability #282
Enable CCPP host model under CMEPS and updates for UFS exchange grid capability #282
Conversation
…exchange grid implementation
Exchange grid updates from Dom 2022/01/30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An impressive amount of work, thanks also for the bug fixes in ccpp-framework. I only skimmed through the CCPP-related parts of this PR. Will need to take a closer look again when it is time to commit, but from what I saw so far it's all looking good.
May want to ask @grantfirl @mkavulich to take a look as well.
@climbfuji the OpnReqTests threading test is failing with newly added RT. I am not sure about the source of it but answer changes when threading activated. I'll try to borrow down the issue but I just wonder if I need to be careful about CCPP host under CMEPS with threading. As I know the CCPP/physics has capability for threading. So, let me know what do you think? |
@climbfuji I have also issue with restart test but this is more complicated then threading and might require splitting FV3 physics to call the CMEPS aoflux phase between them to allow calling aoflux phase in the same execution order with FV3/CCPP sfc_ocean. Anyway, let me know if you have also suggestion about it. |
@jedwards4b i am getting error if I try to test cesm2_3_beta08 with updated CMEPS and CIME. Maybe it is not possible to test beta08 under this configuration.
|
Yes I'm sorry to have wasted your time. I will discuss with @mvertens at 4 today. |
@jedwards4b No worries. In any case, i am still debugging something with threading and it could take little bit time. So, I don't have rush for this PR at this point. |
BTW, we have another CESM baseline for testing at least. |
@jedwards4b please do not merge this until you get confirmation from me. I am still working on fixing restart and threading ORT tests. The last commit dfdb479 seems fixed the restart issue but I just tested it manually. So, I'll update you about it. |
@climbfuji @grantfirl As we discussed in the today's exchange grid call, I would like to update you about the current progress of ORT tests (restart and threading) that are failing. I fixed the restart issue and I have only issue with I/O at this point for xgrid case which we are looking with @jedwards4b. The But, I need your guidance about the threading issue. As you knows. tried to set thread number and block size explicitly to 1 with d307cd5 but this seems not working. At this point, I need your suggestion. As you already know that |
@jedwards4b this PR is ready but needs to be coordinated with top level UFS PR. In the mean time, if you want me to do any test, just let me know. Most of the work that I did was in UFS part and I don't think it will affect CESM. |
@jedwards4b i am planing to merge this if you have no any additional review or testing. Then, I will create another PR in NOAA EMC side to update CMEPS overs there. |
Description of changes
This PR aims to bring exchange grid capability to UFS weather model. For this purpose, CMEPS is extended to act as a CCPP host model to calculate atmosphere-ocean fluxes by running CCPP suite files. This feature is currently only available for UFS model.
Specific notes
Contributors other than yourself, if any:
None
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
No
Any User Interface Changes (namelist or namelist defaults changes)?
coupling_mode = nems_frac_aoflux
, It allows to pass mediator calculated atmosphere-ocean fluxes to FV3coupling_mode = nems_frac_aoflux_sbs
, This mode is just for side-by-side comparisons of fluxes calculated on FV3/CCPP and CMEPS/CCPP. In this mode, the fluxes are calculated under mediator but not sent to FV3. So, the results of fully coupled model has no answer change since the fluxes does not received by FV3 but the mediator history files will include also fluxes calculated under mediator.MED_attributes::
group.aoflux_code = 'ccpp'
, It allows to select desired atmosphere-ocean flux scheme. The available options arecesm
(default) andccpp
. Theccpp
option is only available for UFS since it requires to find FV3 sub-directory for CCPP/physics and CCPP/framework.aoflux_ccpp_suite = 'FV3_sfc_ocean'
, The name of the CCPP suite file that will be used to calculate atmosphere-ocean fluxes.nems.configure
and default values works but it might be required in the near future when external land component brings in.true
.1
.true
.2
.true
.false
) or a warmstart/restart (true
). The default value istrue
.true
.true
.true
.Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: