Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pio parameters to nuopc.runconfig input file #275

Merged
merged 11 commits into from
Apr 15, 2022

Conversation

jedwards4b
Copy link
Collaborator

@jedwards4b jedwards4b commented Mar 17, 2022

Description of changes

Update shr_pio_mod, removing mct centric initialization.
Improve logging and make sure logs go to the correct component.
Depends on cime branch async_io_in_esmf

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? bfb

Any User Interface Changes (namelist or namelist defaults changes)?
The modelio namelist has been eliminated and the parameters from that file were moved to nuopc.runconfig,
The xml variable PIO_ASYNC_INTERFACE was changed from a global variable to one that could be set individually
for each component.

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py

    • machines: cheyenne intel
    • details (e.g. failed tests): IRT_N2_Vmct_Ln9.f19_g16_rx1.A.cheyenne_intel fails, apparently expected.
  • (recommended) CESM testlist_drv.xml

    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test

    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail

    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b jedwards4b requested a review from mvertens March 17, 2022 20:21
@mvertens
Copy link
Collaborator

@jedwards4b - are we ready to merge this?

@jedwards4b
Copy link
Collaborator Author

@mvertens There is a failing test I need to fix first, see: ESMCI/cime#4199

@jedwards4b jedwards4b marked this pull request as ready for review April 1, 2022 17:16
@jedwards4b jedwards4b force-pushed the modelio_to_runconfig branch from 4aceddd to d8e82e8 Compare April 6, 2022 13:13
@mvertens
Copy link
Collaborator

@jedwards4b - please summarize the testing you did for this PR. I cannot accept that before then. Also please fill in a summary of the user interface changes and other requested input for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants