-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move pio parameters to nuopc.runconfig input file #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvertens
requested changes
Mar 23, 2022
@jedwards4b - are we ready to merge this? |
@mvertens There is a failing test I need to fix first, see: ESMCI/cime#4199 |
4aceddd
to
d8e82e8
Compare
@jedwards4b - please summarize the testing you did for this PR. I cannot accept that before then. Also please fill in a summary of the user interface changes and other requested input for the PR. |
mvertens
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update shr_pio_mod, removing mct centric initialization.
Improve logging and make sure logs go to the correct component.
Depends on cime branch async_io_in_esmf
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? bfb
Any User Interface Changes (namelist or namelist defaults changes)?
The modelio namelist has been eliminated and the parameters from that file were moved to nuopc.runconfig,
The xml variable PIO_ASYNC_INTERFACE was changed from a global variable to one that could be set individually
for each component.
Testing performed
Testing performed if application target is CESM:
(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
(recommended) CESM testlist_drv.xml
(optional) CESM prealpha test
(other) please described in detail
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: