Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize drydep_nflds to 0 #273

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Mar 3, 2022

Description of changes

initialize drydep_nflds to 0 in seq_drydep_readnl.

Issue found when running CAM test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with the nuopc driver. Got the following error (and preceding log message):

[0] (seq_drydep_init) Number of dry deposition fields transfered is **
================================================================================
= BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
= PID 117892 RUNNING AT i042.cgd.ucar.edu
= EXIT CODE: 9
= CLEANING UP REMAINING PROCESSES
= YOU CAN IGNORE THE BELOW CLEANUP MESSAGES

Specific notes

Contributors other than yourself, if any: N/A

CMEPS Issues Fixed (include github issue #): resolves #272

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No answer changes.

Any User Interface Changes (namelist or namelist defaults changes)? no user interface changes

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers: izumi CAM aux_cam test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with nuopc_driver
    • details (e.g. failed tests): No failures.

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b jedwards4b requested a review from mvertens March 3, 2022 00:38
@mvertens
Copy link
Collaborator

mvertens commented Mar 3, 2022

@peverwhee - can you please summarize what test(s) failed and needed this fix. It would be good to get that in the issue as well. Thanks for finding this and fixing it.

@peverwhee
Copy link
Collaborator Author

@peverwhee - can you please summarize what test(s) failed and needed this fix. It would be good to get that in the issue as well. Thanks for finding this and fixing it.

Good call. Added to the description.

@gold2718
Copy link

gold2718 commented Mar 9, 2022

Can this get merged? If not, what else needs to be done?
We could really use a tag for this (and an upcoming ccs_config_cesm PR) so we can switch CAM to use NUOPC by default.

@jedwards4b jedwards4b merged commit 82ee2f3 into ESCOMP:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number of drydep fields not initialized in seq_drydep_readnl
4 participants