Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aoflux calculation on agrid and add missing error checks #271

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

uturuncoglu
Copy link
Collaborator

@uturuncoglu uturuncoglu commented Feb 24, 2022

Description of changes

This PR aims to fix atmosphere-ocean flux calculation on agrid. It also adds couple of missing check for the ESMF calls.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): #270

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
No, bfb

Any User Interface Changes (namelist or namelist defaults changes)?
No

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

@uturuncoglu
Copy link
Collaborator Author

@mvertens I did not test it under CESM yet. I'll also run at least one S2S configuration (i.e. cpld_control) to see what happens. I am not expecting any issue but it would be nice to be in safe side.

@uturuncoglu
Copy link
Collaborator Author

@mvertens @DeniseWorthen I tested it under UFS by running cpld_control_c96_p8 test and it works without issue.

@mvertens
Copy link
Collaborator

mvertens commented Mar 2, 2022

@uturuncoglu - thank you for fixing this.

@uturuncoglu uturuncoglu merged commit a75898f into ESCOMP:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants