Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition nitrogen stream functionality to datm #158

Merged
merged 9 commits into from
Aug 11, 2022

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Apr 22, 2022

Description of changes

Added nitrogen deposition to datm streams for CLMNDEP, JRA and CORE

Specific notes

Nitrogen deposition is now sent by default from datm to CTSM, POP and MOM6. For now none of the prognostic components will use this field - but this is the first step in removing the component read of ndep from the component itself and obtaining it from an atmospheric component.

Contributors other than yourself, if any: None

CDEPS Issues Fixed: None

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb for now (unless CLM is changed to actually receive this data)

Any User Interface Changes (namelist or namelist defaults changes): only for cime_config

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): the following tests were run and compared to cesm2_3_alpha09b
For CTSM - the data read in was compared to the output when the data was obtained from datm and the results were the same to single precision in comparing the clm history files)

SMS_Ld1.f19_g17.I1850Clm50Bgc.cheyenne_intel
ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default
ERS.TL319_t061_wt061.GMOM_JRA_WD.cheyenne_intel

Hashes used for testing: cesm2_3_alpha09b

@mvertens mvertens marked this pull request as draft April 22, 2022 18:39
@mvertens mvertens force-pushed the feature/ndep_stream branch from c264349 to 4895d59 Compare April 29, 2022 17:27
@mvertens mvertens force-pushed the feature/ndep_stream branch from 4895d59 to 7fed4bb Compare June 21, 2022 19:04
@mvertens mvertens marked this pull request as ready for review June 23, 2022 19:21
@mvertens
Copy link
Collaborator Author

mvertens commented Aug 9, 2022

@uturuncoglu - this has become a priority to CTSM to get this on master.
Could you please test/review it and make sure that it works for you. Thanks!

@uturuncoglu
Copy link
Collaborator

@mvertens Sorry for delay. I took off this afternoon. Anyway, I tested with UFS and run couple of data atmosphere configurations like followings,

  • datm_cdeps_control_cfsr
  • hafs_regional_datm_cdeps
    and all are passed. So, I think this PR is fine for UFS.

@mvertens
Copy link
Collaborator Author

@uturuncoglu - thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants