-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition nitrogen stream functionality to datm #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c264349
to
4895d59
Compare
4895d59
to
7fed4bb
Compare
jedwards4b
approved these changes
Jun 24, 2022
@uturuncoglu - this has become a priority to CTSM to get this on master. |
uturuncoglu
approved these changes
Aug 10, 2022
@mvertens Sorry for delay. I took off this afternoon. Anyway, I tested with UFS and run couple of data atmosphere configurations like followings,
|
@uturuncoglu - thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added nitrogen deposition to datm streams for CLMNDEP, JRA and CORE
Specific notes
Nitrogen deposition is now sent by default from datm to CTSM, POP and MOM6. For now none of the prognostic components will use this field - but this is the first step in removing the component read of ndep from the component itself and obtaining it from an atmospheric component.
Contributors other than yourself, if any: None
CDEPS Issues Fixed: None
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb for now (unless CLM is changed to actually receive this data)
Any User Interface Changes (namelist or namelist defaults changes): only for cime_config
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): the following tests were run and compared to cesm2_3_alpha09b
For CTSM - the data read in was compared to the output when the data was obtained from datm and the results were the same to single precision in comparing the clm history files)
SMS_Ld1.f19_g17.I1850Clm50Bgc.cheyenne_intel
ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default
ERS.TL319_t061_wt061.GMOM_JRA_WD.cheyenne_intel
Hashes used for testing: cesm2_3_alpha09b