Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

dependency on third-party distributions #8984

Closed
cc32d9 opened this issue Apr 21, 2020 · 3 comments
Closed

dependency on third-party distributions #8984

cc32d9 opened this issue Apr 21, 2020 · 3 comments

Comments

@cc32d9
Copy link
Contributor

cc32d9 commented Apr 21, 2020

The EOSIO repository depends on submodules from third-party authors on Github. Those libraries may eventually disappear or break. Some of these libraries, like https://github.com/cryptonomex/secp256k1-zkp.git haven't been updated since long time (2015). secp256k1-zkp has also no master branch which causes errors in recursive submodules upgrades.

I believe B1 needs to maintain clones of those repositories that the software depends upon.

@spoonincode
Copy link
Contributor

@cc32d9 you called out the secp256k1 fork explicitly, and I think that concern was reasonable. Now that it's resolved are there others you'd like to see handled differently?

@cc32d9
Copy link
Contributor Author

cc32d9 commented Jan 28, 2021

I don't know, but basically any removal of a dependency repository will disrupt the process, so it makes sense to clone all third-party repos

@spoonincode
Copy link
Contributor

Unless there is a specific concern I would vote to close this. We have to draw the line somewhere -- we can't mirror the entire Ubuntu source code or something. Most of the current deps are quite high profile and unlikely to disappear IMO. Since this is tracked in Jira, calling @aclark-b1 for input

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants