Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

state_history_plugin LIB notification lags LIB #8951

Open
heifner opened this issue Apr 15, 2020 · 0 comments
Open

state_history_plugin LIB notification lags LIB #8951

heifner opened this issue Apr 15, 2020 · 0 comments

Comments

@heifner
Copy link
Contributor

heifner commented Apr 15, 2020

The state_history_plugin get_blocks_result_v0 last_irreversible lags behind actual LIB by ~500ms as LIB is updated after the accepted_block signal which is used to send out the get_blocks_result_v0 message.

PR #8927 fixes a similar problem with get_blocks_result_v0 head lagging behind actual head by ~500ms by using the signaled head instead of reaching back into the controller and accessing the current head which has not been updated at the time of the signal.

To fix this problem, signal'ed methods should not reach back into the controller for information not contained in the signal as there is no current guarantee of the values during these signals.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants