[Bug]: UnboundLocalError: local variable 'cwv_max' referenced before assignment for arm_diags plot with region sgpc1

[tomvothecoder]

What happened?

There is a FIXME: comment to address this for awhile:

e3sm_diags/e3sm_diags/plot/cartopy/arm_diags_plot.py

Lines 177 to 178 in 2b303df

	# FIXME: UnboundLocalError: local variable 'cwv_max' referenced before assignment
	number_of_bins = int(np.ceil((cwv_max - cwv_min) / bin_width))

What did you expect to happen? Are there are possible answers you came across?

This occurs when the region is sgpc1. The conditional that sets cwv_max and other plotting variables don't consider this region:

e3sm_diags/e3sm_diags/plot/cartopy/arm_diags_plot.py

Lines 136 to 156 in 2b303df

	# Define cwc bounds and bin_width for each site
	if region == "twpc1": # twpc1
	cwv_max = 69
	cwv_min = 28
	bin_width = 1.5
	sitename = "Manus Island"
	if region == "twpc2": # twpc2
	cwv_max = 70
	cwv_min = 28
	bin_width = 2.0
	sitename = "Nauru"
	if region == "twpc3": # twpc3
	cwv_max = 85
	cwv_min = 28
	bin_width = 2.0
	sitename = "Darwin"
	if region == "sgp": # sgp
	cwv_max = 75
	cwv_min = 20
	bin_width = 2.0
	sitename = "SGP"

Minimal Complete Verifiable Example (MVCE)

No response

Relevant log output

No response

Anything else we need to know?

No response

Environment

Latest main and cdat-migration-fy24 branch

[tomvothecoder]

Hey @chengzhuzhang, this bug has been around for a long time. I can now fix it in #842.

Do you have an idea what the values should be for cwv_max, cwv_min, bin_width, and sitename?

[chengzhuzhang]

I think there is a typo:

e3sm_diags/e3sm_diags/plot/cartopy/arm_diags_plot.py

Line 152 in 2b303df

if region == "sgp": # sgp

It should be
if region == "sgpc1":

[tomvothecoder]

Closed by #842