Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new version of AIS 4km mesh #6884

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

matthewhoffman
Copy link
Contributor

This PR update the GLC mpas.ais4to20km mesh to a new version that has corrected some artifacts in ice shelf and grounding line position in the Amundsen Sea. This AIS geometry will also be used to define AIS geometry in MPAS-Ocean as part of the in-development SOwISC12to30E3r4 ocean mesh.

This mesh has corrected some artifacts in ice shelf and grounding line
position in the Amundsen Sea.  This AIS geometry will be used to define
AIS geometry in MPAS-Ocean as part of the in-development
SOwISC12to30E3r4 ocean mesh.
@matthewhoffman
Copy link
Contributor Author

I tested on Chrysalis with:

./create_test --wait --walltime 1:00:00 SMS_Ld5.TL319_IcoswISC30E3r5_ais4to20.MPAS_FOLISIO_JRA1p5.chrysalis_gnu.mpaso-ocn_glcshelf

Test passed.

Copy link
Contributor

@trhille trhille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @matthewhoffman's test results.

@jonbob jonbob added the BFB PR leaves answers BFB label Jan 21, 2025
jonbob added a commit that referenced this pull request Jan 21, 2025
…6884)

Update to new version of AIS 4km mesh

This PR update the GLC mpas.ais4to20km mesh to a new version that has
corrected some artifacts in ice shelf and grounding line position in the
Amundsen Sea. This AIS geometry will also be used to define AIS geometry
in MPAS-Ocean as part of the in-development SOwISC12to30E3r4 ocean mesh.

[BFB] for all currently tested configurations
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing and visual inspection

@jonbob
Copy link
Contributor

jonbob commented Jan 21, 2025

Passes:

  • e3sm_landice_developer on chrysalis with gnu compiler
  • SMS_Ld5.TL319_IcoswISC30E3r5_ais4to20.MPAS_FOLISIO_JRA1p5.chrysalis_gnu.mpaso-ocn_glcshelf

merged to next

@jonbob jonbob merged commit 5f2adef into master Jan 22, 2025
4 checks passed
@jonbob jonbob deleted the matthewhoffman/mali/update-ais4km-mesh branch January 22, 2025 17:22
@jonbob
Copy link
Contributor

jonbob commented Jan 22, 2025

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-albany-landice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants