Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign alkalinity equals DIC in sea ice melt #6236

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

maltrud
Copy link
Contributor

@maltrud maltrud commented Feb 13, 2024

Set alkalinity of sea ice melt flux into the ocean to be equal to DIC flux, analogous to what is done with river runoff. Previously the flux was zero, resulting in unphysical dilution.

Fixes #6210.

Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6236/
on branch gh-pages at 2024-02-13 22:07 UTC

@rljacob
Copy link
Member

rljacob commented Feb 29, 2024

@katsmith133 please review.

jonbob added a commit that referenced this pull request Mar 6, 2024
Assign alkalinity equals DIC in sea ice melt

Set alkalinity of sea ice melt flux into the ocean to be equal to DIC
flux, analogous to what is done with river runoff. Previously the flux
was zero, resulting in unphysical dilution.

Fixes #6210

[BFB] for all current tests
@jonbob
Copy link
Contributor

jonbob commented Mar 6, 2024

Passes:

  • SMS_Ld2.ne30pg2_r05_IcoswISC30E3r5.BGCEXP_CNTL_CNPRDCTC_1850.chrysalis_intel.elm-bgcexp
  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel

merged to next

@jonbob jonbob merged commit a3f2186 into master Mar 11, 2024
3 checks passed
@jonbob jonbob deleted the maltrud/ocean/seaice-melt-alkalinity branch March 11, 2024 19:35
@jonbob
Copy link
Contributor

jonbob commented Mar 11, 2024

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sea ice melt water has no alkalinity.
4 participants