Fix bug in stealth feature log-law drag #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2023
mark-petersen
approved these changes
Nov 8, 2023
|
@mark-petersen Thanks for reviewing! |
|
@cbegeman I ran with the fix you made and the |
|
@gcapodag Thanks for testing and for uncovering this issue. |
|
@jonbob I think this has been sufficiently tested that we can move forward when you're ready. Absolutely no rush on this though. |
|
notes: ready but low priority. In standalone tests. |
jonbob
added a commit
that referenced
this pull request
Dec 14, 2023
Fix bug in stealth feature log-law drag The indices of kineticEnergyCell in the log-law drag function raised an error on perlmutter with gnu, mpich debug=on. This PR fixes the indexing. Fixes #6055 [BFB]
|
passes:
merged to next |
|
merged to master |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indices of
kineticEnergyCellin the log-law drag function raised an error on perlmutter with gnu, mpich debug=on. This PR fixes the indexing.Migrated from E3SM-Ocean-Discussion#71.
Fixes #6055.