Support for HDF5 I/O format in E3SM #6046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jgfouca
approved these changes
Nov 2, 2023
|
@jayeshkrishna Maybe we can add support for HDF5 in MPAS with another PR later, similar to #5490. |
jgfouca
added a commit
that referenced
this pull request
Nov 16, 2023
Support for HDF5 I/O format in E3SM Adding support for the HDF5 I/O format which is already available in SCORPIO. Also using HDF5_ROOT in buildlib.spio to turn on HDF5 support. [BFB] * origin/dqwu/add_hdf5_iotype: Removing redundant env var WITH_HDF5_SCORPIO in buildlib.spio Adding support for HDF5 iotype
jayeshkrishna
approved these changes
Nov 16, 2023
|
This PR will be rebased and re-merged to next branch after PR #6069 is merged to E3SM master. |
Add HDF5 typename to valid values of PIO_TYPENAME and support conversion of HDF5 typename to PIO type.
If HDF5_ROOT is already set as an env var, it is sufficient to turn on the WITH_HDF5 CMake option for scorpio. Introducing a new env var like WITH_HDF5_SCORPIO may lead to unnecessary confusion. Additionally, for now, maintain the WITH_HDF5 CMake option as OFF by default to prevent potential build errors with the default scorpio 1.4.2 submodule.
b0d9e51 to
34b0875
Compare
jgfouca
added a commit
that referenced
this pull request
Dec 4, 2023
Adding support for the HDF5 I/O format which is already available in SCORPIO. Also using HDF5_ROOT in buildlib.spio to turn on HDF5 support. [BFB]
|
Merged to next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the HDF5 I/O format which is already available
in SCORPIO.
Also using HDF5_ROOT in buildlib.spio to turn on HDF5 support.
[BFB]