Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused variables in ocean #5610

Merged
merged 1 commit into from
Apr 28, 2023
Merged

remove unused variables in ocean #5610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions components/mpas-ocean/src/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3756,10 +3756,6 @@
description="Equilibrium tidal potential"
packages="forwardMode"
/>
<var name="nTidalPotentialConstituents" type="integer" dimensions="Time"
description="Number of tidal constituents"
packages="tidalPotentialForcingPKG"
/>
<var name="tidalPotentialConstituentFrequency" type="real" dimensions="maxTidalConstituents Time" units="s^-1"
description="Frequency of tidal constituents"
packages="tidalPotentialForcingPKG"
Expand Down Expand Up @@ -3792,10 +3788,6 @@
description="Latitude function for tidal constituents: long-period = 3\sin^2(\phi)-1, diurnal = \sin(2\phi), semi-diurnal = \cos^2(\phi)"
packages="tidalPotentialForcingPKG"
/>
<var name="tidalPotentialZMid" type="real" dimensions="nVertLevels nCells Time" units="m"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrus89 please verify that I can remove tidalPotentialZMid. It appears to be a remnant of something during development.

description="zMid - Equilibrium tidal potential in RK4"
packages="tidalPotentialForcingPKG"
/>
<var name="sshSubcycleCurWithTides" type="real" dimensions="nCells Time" units="m"
description="SSH - tidal potential in split explicit "
packages="tidalPotentialForcingPKG"
Expand Down
7 changes: 0 additions & 7 deletions components/mpas-ocean/src/shared/mpas_ocn_vel_tidal_potential.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ subroutine ocn_vel_tidal_potential_init(domain,err)!{{{
type (mpas_pool_type), pointer :: forcingPool
type (mpas_pool_type), pointer :: meshPool
integer, pointer :: nCells
integer, pointer :: nTidalPotentialConstituents
real (kind=RKIND), dimension(:), pointer :: latCell

! End preamble
Expand Down Expand Up @@ -358,9 +357,6 @@ subroutine ocn_vel_tidal_potential_init(domain,err)!{{{
call mpas_pool_get_array(forcingPool, 'tidalPotentialEta', &
tidalPotEta)

call mpas_pool_get_array(forcingPool, &
'nTidalPotentialConstituents', &
nTidalPotentialConstituents)
call mpas_pool_get_array(forcingPool, &
'tidalPotentialConstituentAmplitude', &
tidalConstituentAmplitude)
Expand Down Expand Up @@ -434,9 +430,6 @@ subroutine ocn_vel_tidal_potential_init(domain,err)!{{{
constituentList(nTidalConstituents)%constituent = 'P1'
end if

! set point value in forcing pool just in case
nTidalPotentialConstituents = nTidalConstituents
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrus89 please check if I can remove nTidalPotentialConstituents. It looks like you added it to record information during development. This would never change, so I suspect you don't need it anymore. The gnu compiler seems to think you don't need it either.


call tidal_constituent_factors(constituentList, &
nTidalConstituents, refTime, &
tidalConstituentFrequency, &
Expand Down