Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in the SI solver issued by #5598 #5600

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix a bug in the SI solver issued by #5598 #5600

merged 1 commit into from
Apr 17, 2023

Conversation

hyungyukang
Copy link
Contributor

@hyungyukang hyungyukang commented Apr 14, 2023 •
edited by jonbob
Loading

The standalone MPAS-O build was broken due to a missing 'USE_LAPACK' directive in the SI solver code (issued by #5598).

Fixes #5598

[BFB]

@hyungyukang
Fix a bug issued by #5598
47f0bca 
- The standalone MPAS-O build was broken due to a missing 'USE_LAPACK' directive in the SI solver code.
@hyungyukang hyungyukang requested a review from xylar April 14, 2023 12:57
@hyungyukang
Copy link
Contributor Author

hyungyukang commented Apr 14, 2023 •
edited
Loading

@xylar , could you please try to build the standalone MPAS-O using this branch before merging?

@xylar
Copy link
Contributor

xylar commented Apr 14, 2023

Great, I'll try this soon! Thanks for working on this so quickly.

@xylar
Copy link
Contributor

xylar commented Apr 14, 2023

I can confirm that the standalone MPAS-Ocean model builds with this fix. I'm going to do a test run now.

xylar
xylar approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @hyungyukang!

I was able to run the pr test suite from Compass on Chrysalis with Intel, OpenMPI and OpenMP with this branch. 5 tests with ice-shelf cavities failed for know reasons unrelated to the PR (they are because of #5464 and will be fixed in MPAS-Dev/compass#512). But all the rest were successful so this is perfect as far as I'm concerned.

@hyungyukang
Copy link
Contributor Author

Thanks again, @hyungyukang!

I was able to run the pr test suite from Compass on Chrysalis with Intel, OpenMPI and OpenMP with this branch. 5 tests with ice-shelf cavities failed for know reasons unrelated to the PR (they are because of #5464 and will be fixed in MPAS-Dev/compass#512). But all the rest were successful so this is perfect as far as I'm concerned.

Great! Thanks for testing, @xylar !

philipwjones
philipwjones approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve by inspection - thanks @hyungyukang

@jonbob jonbob added the BFB PR leaves answers BFB label Apr 14, 2023
jonbob added a commit that referenced this pull request Apr 14, 2023
@jonbob
Merge branch 'hkang/ocean/si-bug-fix' into next (PR #5600)
bb05467 
Fix a bug in the SI solver

Fixes a bug in the standalone MPAS-O build that was broken due to a
missing 'USE_LAPACK' directive in the SI solver code (issued by #5598).

Fixes #5598

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Apr 14, 2023

passes:

  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel
  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel
  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod

merged to next

@jonbob jonbob merged commit 4b3e611 into master Apr 17, 2023
@jonbob jonbob deleted the hkang/ocean/si-bug-fix branch April 17, 2023 18:18
@jonbob
Copy link
Contributor

jonbob commented Apr 17, 2023

merged to master

xylar added a commit to xylar/compass that referenced this pull request Apr 18, 2023
@xylar
Update E3SM-Project submodule
23d228a 
This merge updates the E3SM-Project submodule from [c292bec000](https://github.com/E3SM-Project/E3SM/tree/c292bec000) to [4b3e611fee](https://github.com/E3SM-Project/E3SM/tree/4b3e611fee).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5418
- [ ]  (ocn) E3SM-Project/E3SM#5447
- [ ]  (ocn) E3SM-Project/E3SM#5568
- [ ]  (ocn) E3SM-Project/E3SM#5583
- [ ]  (ocn) E3SM-Project/E3SM#5575
- [ ]  (ocn) E3SM-Project/E3SM#5600
@xylar xylar mentioned this pull request Apr 18, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

@philipwjones philipwjones philipwjones approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB bug fix PR mpas-ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standalone MPAS-Ocean builds broken
4 participants
@hyungyukang @xylar @jonbob @philipwjones