Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for ADIOS in MPAS #5490

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Adding support for ADIOS in MPAS #5490

merged 1 commit into from
Mar 16, 2023

Conversation

jayeshkrishna
Copy link
Contributor

Adding support for the ADIOS I/O format

[BFB]

@jayeshkrishna
Adding support for ADIOS
fd4f120 
Adding support for ADIOS in MPAS. This change would allow MPAS
users to specify the ADIOS I/O type using the streams file.
@jayeshkrishna jayeshkrishna added BFB PR leaves answers BFB SCORPIO The E3SM I/O library (derived from PIO) mpas-framework labels Mar 2, 2023
@jayeshkrishna jayeshkrishna requested a review from jonbob March 2, 2023 03:16
This was referenced Mar 2, 2023
Merged
Merged
@jonbob jonbob requested a review from xylar March 10, 2023 18:02
@jonbob
Copy link
Contributor

jonbob commented Mar 10, 2023

@xylar - can you please take a look at this and make sure it (or PR #5489 which I already merged) won't impact standalone mpas-o?

@xylar
Copy link
Contributor

xylar commented Mar 10, 2023

@jonbob, I'm really glad you pinged me because I would have thought this was a no-brainer. I'm seeing 2 thread decomposition tests failing on Chrysalis with Intel and OpenMPI:

ocean/baroclinic_channel/10km/decomp_test
  * step: initial_state
  * step: 4proc
  * step: 8proc
  test execution:      SUCCESS
  test validation:     FAIL
  see: case_outputs/ocean_baroclinic_channel_10km_decomp_test.log
  test runtime:        00:03
ocean/global_ocean/QU240/PHC/decomp_test
  * step: 4proc
  * step: 8proc
  test execution:      SUCCESS
  test validation:     FAIL
  see: case_outputs/ocean_global_ocean_QU240_PHC_decomp_test.log
  test runtime:        00:58

@jonbob and @jayeshkrishna, could you take a look and see if there are any obvious changes that might explain threading problems? The differences across thread counts are at machine precision but aren't bit-for-bit, which we can't allow.

@xylar
Copy link
Contributor

xylar commented Mar 10, 2023

My tests are in:

/lcrc/group/e3sm/ac.xylar/compass_1.2/chrysalis/test_20230310/pr_adios

@xylar
Copy link
Contributor

xylar commented Mar 10, 2023

It occurs to me that I haven't tested on the latest master. The treading issue could have come from a previous merge.

@xylar
Copy link
Contributor

xylar commented Mar 10, 2023 •
edited
Loading

I see. This branch is off of a very old master (from November). I'll try doing a test merge with the current master and running again. (Thankfully, my tests on master are working fine.)

@xylar
Copy link
Contributor

xylar commented Mar 10, 2023

After the merge with master, the pr test suite passes on Chrysalis with Openmpi. Sorry for the confusion earlier.

@jonbob
Copy link
Contributor

jonbob commented Mar 10, 2023

@xylar -- whew, I'm so glad to hear it was OK in the end. I'll be more aware and include you on any PRs that touch those kinds of MPAS files

jonbob added a commit that referenced this pull request Mar 15, 2023
@jonbob
Merge branch 'jayeshkrishna/mpas-framework/add_adios' into next (PR #…
70ad648 
…5490)

Adding support for ADIOS in MPAS

Adding support for the ADIOS I/O format

[BFB]
jonbob
jonbob approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing inside E3SM and Xylar's mpas-o tests

@jonbob
Copy link
Contributor

jonbob commented Mar 15, 2023

passes:

  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel
  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod

merged to next

@jonbob jonbob merged commit 8018a7a into master Mar 16, 2023
@jonbob jonbob deleted the jayeshkrishna/mpas-framework/add_adios branch March 16, 2023 17:45
@jonbob
Copy link
Contributor

jonbob commented Mar 16, 2023

merged to master

xylar added a commit to xylar/compass that referenced this pull request Apr 2, 2023
@xylar
Update E3SM-Project submodule
50032c4 
This merge updates the E3SM-Project submodule from [c9201a4](https://github.com/E3SM-Project/E3SM/tree/c9201a4f44540bb74cb3650e32bcbe27fb762ab1) to [b4d5b10600](https://github.com/E3SM-Project/E3SM/tree/b4d5b10600).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5254
- [ ]  (fwk) E3SM-Project/E3SM#5490
- [ ]  (ocn) E3SM-Project/E3SM#5541
- [ ]  (fwk) E3SM-Project/E3SM#5498
- [ ]  (ocn) E3SM-Project/E3SM#5564
- [ ]  (ocn) E3SM-Project/E3SM#5553
- [ ]  (ocn) E3SM-Project/E3SM#5519
@xylar xylar mentioned this pull request Apr 2, 2023
Merged
8 tasks
@xylar xylar mentioned this pull request May 26, 2023
Merged
@dqwu dqwu mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xylar xylar xylar approved these changes

@jonbob jonbob jonbob approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-framework SCORPIO The E3SM I/O library (derived from PIO)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayeshkrishna @jonbob @xylar