Add missing code to set threadNum before its use #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mark-petersen - I added you in part so you could decide if we need to pass this along to Michael Duda |
ambrad
approved these changes
Nov 29, 2022
|
passes sanity testing, merged to next |
mark-petersen
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
@ambrad thanks for pointing this out. threadNum is used but uninitialized, so this is an obvious correction.
xylar
added a commit
to xylar/compass
that referenced
this pull request
Dec 15, 2022
This merge updates the E3SM-Project submodule from [569ed6b730](https://github.com/E3SM-Project/E3SM/tree/569ed6b730) to [0273cfad9d](https://github.com/E3SM-Project/E3SM/tree/0273cfad9d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5306 - [ ] (fwk) E3SM-Project/E3SM#5303 - [ ] (ocn) E3SM-Project/E3SM#5325 - [ ] (fwk) E3SM-Project/E3SM#5337 - [ ] (fwk) E3SM-Project/E3SM#5123 - [ ] (fwk) E3SM-Project/E3SM#5281 - [ ] (ocn) E3SM-Project/E3SM#5356
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a variable threadNum was used before it was set
Fixes #5333
[BFB]