Mask ocean time series stats variables #5325
Conversation
There was a problem hiding this comment.
I ran the CMPASO-JRA1p4_TL319_EC30to60E2r2 test case for a month and took a look at masking for a random sampling of different time series stats variables for which masking has been turned on in this PR. Everything looked good to me. Results are at:
/lcrc/group/e3sm/ac.xasay-davis/scratch/chrys/20221129.CMPASO-JRA1p4_TL319_EC30to60E2r2.fix-time-series-stats.chrysalis/run
|
@darincomeau, can you take a look at this when you get a chance? It would be great to have another test or at least another pair of eyes on the test results I just produced before this goes in. |
|
I ran a one month G case here: Looking through |
|
@darincomeau Thanks so much for reviewing! |
|
passes:
merged to next |
|
merged to master |
|
@jonbob Thanks for your testing! I'm happy that we're a little closer to CF compliance |
|
@cbegeman - you make it very easy |
This merge updates the E3SM-Project submodule from [569ed6b730](https://github.com/E3SM-Project/E3SM/tree/569ed6b730) to [0273cfad9d](https://github.com/E3SM-Project/E3SM/tree/0273cfad9d). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5306 - [ ] (fwk) E3SM-Project/E3SM#5303 - [ ] (ocn) E3SM-Project/E3SM#5325 - [ ] (fwk) E3SM-Project/E3SM#5337 - [ ] (fwk) E3SM-Project/E3SM#5123 - [ ] (fwk) E3SM-Project/E3SM#5281 - [ ] (ocn) E3SM-Project/E3SM#5356
This PR applies fill value masking to non-restart time series stats streams in the ocean component. It also specifies the masking array for a subset of variables in the Registry.
It builds on the PRs that add the masking option to the framework, #5154 and #5251. Discussion can be found at E3SM-Ocean-Discussion#32.
Fixes #5253
[BFB]