Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default ocn settings for Cryo v2 configurations #5306

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

darincomeau
Copy link
Member

Changes default ocn namelist settings for configurations using the Cryo v2 ocn/ice grids ECwISC30to60E2r1 and SOwISC12to60E2r4, primarily relating to the GM closure.

[BFB] for all configurations not using ECwISC30to60E2r1, SOwISC12to60E2r4 ocn/ice grids.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks right to me. @darincomeau if these are the settings you've been using for the last set of cryo runs, then we should add them. Thanks for updating!

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on our current best simulation results, this looks right to me.

Copy link
Contributor

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@stephenprice stephenprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for holding things up. These look great to me too.

jonbob added a commit that referenced this pull request Nov 21, 2022
…5306)

Change default ocn settings for Cryo v2 configurations

Changes default ocn namelist settings for configurations using the Cryo
v2 ocn/ice grids ECwISC30to60E2r1 and SOwISC12to60E2r4, primarily
relating to the GM closure.

[BFB] for all configurations not using ECwISC30to60E2r1,
      SOwISC12to60E2r4 ocn/ice grids
@jonbob
Copy link
Contributor

jonbob commented Nov 21, 2022

Passes:

  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod
  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel
  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel

merged to next

@jonbob jonbob merged commit 64bc598 into master Nov 22, 2022
@jonbob jonbob deleted the darincomeau/ocn/change-cryov2-defaults branch November 22, 2022 17:15
@jonbob
Copy link
Contributor

jonbob commented Nov 22, 2022

merged to master

xylar added a commit to xylar/compass that referenced this pull request Dec 15, 2022
This merge updates the E3SM-Project submodule from [569ed6b730](https://github.com/E3SM-Project/E3SM/tree/569ed6b730) to [0273cfad9d](https://github.com/E3SM-Project/E3SM/tree/0273cfad9d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5306
- [ ]  (fwk) E3SM-Project/E3SM#5303
- [ ]  (ocn) E3SM-Project/E3SM#5325
- [ ]  (fwk) E3SM-Project/E3SM#5337
- [ ]  (fwk) E3SM-Project/E3SM#5123
- [ ]  (fwk) E3SM-Project/E3SM#5281
- [ ]  (ocn) E3SM-Project/E3SM#5356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants