Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing time level index to 'ssh' coupling field #5305

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

darincomeau
Copy link
Member

@darincomeau darincomeau commented Nov 15, 2022

This adds a time level index that was missing from an 'ssh' call. The missing index results in the following warnings being printed to ocn.log.* every timestep in certain configurations (GMPAS-*.*wISC*):

WARNING: Error: Field ssh has more than one time level, but no timeLevel argument given.

With this fix (h/t @xylar), those warning messages no longer appear.

Fixes #5287.

[BFB] for all currently tested configurations.

Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An important fix! Looks good.

Copy link
Contributor

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for catching this @darincomeau!

jonbob added a commit that referenced this pull request Nov 17, 2022
)

Add missing time level index to 'ssh' coupling field

This adds a time level index that was missing from an 'ssh' call. The
missing index results in the following warnings being printed to
ocn.log.* every timestep in certain configurations (GMPAS-*.*wISC*):
   WARNING: Error: Field ssh has more than one time level, but no
                   timeLevel argument given.
With this fix (h/t @xylar), those warning messages no longer appear.

Fixes #5287

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Nov 17, 2022

passes:

  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel
  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod
  • SMS_D_Ld3.T62_oQU120.CMPASO-IAF.chrysalis_intel

merged to next

@jonbob jonbob merged commit b2bbb2a into master Nov 18, 2022
@jonbob jonbob deleted the darincomeau/ocn/fix-missing-ssh-index branch November 18, 2022 17:52
@jonbob
Copy link
Contributor

jonbob commented Nov 18, 2022

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB bug fix PR mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning error for 'ssh' variable in ocn.log
4 participants