Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPAS standalone] Clean up "*-nersc" build targets #5281

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[MPAS standalone] Clean up "*-nersc" build targets #5281

merged 1 commit into from
Dec 13, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Nov 9, 2022 •
edited by jonbob
Loading

Remove pgi-nersc and cray-nersc, which are not used or supported.

Rename intel-nersc and gnu-nersc to intel-cray and gnu-cray, respectively, as they should work on other cray machines as well such as Chicoma.

[BFB]

@xylar
Clean up "*-nersc" build targets
11f5588 
Remove `pgi-nersc` and `cray-nersc`, which are not used or supported.

Rename `intel-nersc` and `gnu-nersc` to `intel-cray` and
`gnu-cray`, respectively, as they should work on other cray machines
as well such as Chicoma.
@xylar xylar added BFB PR leaves answers BFB mpas-framework labels Nov 9, 2022
mark-petersen
mark-petersen approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection. Thanks for the clean-up.

matthewhoffman
matthewhoffman approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar , out of curiosity, did you actually try gnu-cray on chicoma? I'm fine with the rename either way, so approving.

@xylar
Copy link
Contributor Author

xylar commented Nov 10, 2022

@matthewhoffman, no but I have tried the old gnu-nersc on Chicoma. That's what we have to use. That's the motivation for the change.

philipwjones
philipwjones approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to see if I could also add the nvidia-cray and cray-cray (gonna love that name) options for both pm-gpu and crusher/frontier, but looks like that wasn't going to be as quick as I thought, so will put those into a later PR and not hold this one up. Looks good to me.

@xylar
Copy link
Contributor Author

xylar commented Nov 10, 2022

Hmm, yeah, cray-cray is an odd (maybe great!?). Hadn't thought through the implications of this naming convention.

If you have an alternative suggestion (that isn't -nersc), I'm fine with it.

@philipwjones
Copy link
Contributor

Kinda like being able to say Frontier is cray-cray. If you don't want that, you could use craywrap or something, but that adds more typing.

@rljacob rljacob modified the milestone: v2.1rc Dec 1, 2022
akturner
akturner approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@akturner akturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection

jonbob added a commit that referenced this pull request Dec 12, 2022
@jonbob
Merge branch 'xylar/mpas-framework/rename-nersc-build-targets-to-cray…
33fe779 
…' into next (PR #5281)

Clean up "*-nersc" build targets in MPAS standlone build system

Remove pgi-nersc and cray-nersc, which are not used or supported.
Rename intel-nersc and gnu-nersc to intel-cray and gnu-cray,
espectively, as they should work on other cray machines as well such as
Chicoma.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Dec 12, 2022

passes sanity testing, merged to next

@jonbob jonbob merged commit 8dac39f into E3SM-Project:master Dec 13, 2022
@jonbob
Copy link
Contributor

jonbob commented Dec 13, 2022

merged to master

@xylar
Copy link
Contributor Author

xylar commented Dec 13, 2022

Thank you, @jonbob!

xylar added a commit to xylar/compass that referenced this pull request Dec 15, 2022
@xylar
Update E3SM-Project submodule
21f8a56 
This merge updates the E3SM-Project submodule from [569ed6b730](https://github.com/E3SM-Project/E3SM/tree/569ed6b730) to [0273cfad9d](https://github.com/E3SM-Project/E3SM/tree/0273cfad9d).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5306
- [ ]  (fwk) E3SM-Project/E3SM#5303
- [ ]  (ocn) E3SM-Project/E3SM#5325
- [ ]  (fwk) E3SM-Project/E3SM#5337
- [ ]  (fwk) E3SM-Project/E3SM#5123
- [ ]  (fwk) E3SM-Project/E3SM#5281
- [ ]  (ocn) E3SM-Project/E3SM#5356
@xylar xylar mentioned this pull request Dec 15, 2022
Merged
9 tasks
@xylar xylar deleted the mpas-framework/rename-nersc-build-targets-to-cray branch August 27, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-petersen mark-petersen mark-petersen approved these changes

@matthewhoffman matthewhoffman matthewhoffman approved these changes

@akturner akturner akturner approved these changes

@philipwjones philipwjones philipwjones approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xylar @philipwjones @jonbob @mark-petersen @matthewhoffman @akturner @rljacob