-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[standalone MPAS] Finalize PIO when finalizing MPAS i/o #5152
[standalone MPAS] Finalize PIO when finalizing MPAS i/o #5152
Conversation
This allows SCORPIO to print out timing information needed for some types of debugging.
See discussion PR E3SM-Ocean-Discussion#30 for additional context. |
TestingI ran the compass ocean I ran the |
@jonbob, would you like me to do further E3SM testing on this to make sure I'm doing no harm? Happy to run whatever tests you suggest. |
@xylar - I'll do more testing before I merge, so I think this looks fine. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This functions for the ocean core. Tested with gnu and intel, both debug and optimized, nightly suite on badger. Also compares bfb against branch point with gnu optimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on discussion yesterday, inspection, and Mark's testing. This appears to be the proper implementation that mirrors the init operations.
Thanks for these reviews as well, @matthewhoffman and @mark-petersen! Much appreciated. @akturner, this is lower priority than #5162 for me but would appreciate you having a look at this soon, too, if you can. |
Thanks @akturner! |
Test merge passes sanity testing on chrysalis:
will merge to next as soon as the repo is open |
…5152) Finalize PIO when finalizing MPAS i/o in MPAS Standalone This allows SCORPIO to print out timing information needed for some types of debugging. pio_finalize() is only called in standalone. If MPAS components are run as part of an E3SM run, the PIO context is passed to MPAS and this signals that the MPAS framework should not finalize PIO. [BFB]
merged to next |
merged to master |
This allows SCORPIO to print out timing information needed for some types of debugging.
pio_finalize()
is only called in standalone. If MPAS components are run as part of an E3SM run, the PIO context is passed to MPAS and this signals that the MPAS framework should not finalize PIO.