Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[standalone MPAS] Finalize PIO when finalizing MPAS i/o #5152

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Aug 24, 2022

This allows SCORPIO to print out timing information needed for some types of debugging.

pio_finalize() is only called in standalone. If MPAS components are run as part of an E3SM run, the PIO context is passed to MPAS and this signals that the MPAS framework should not finalize PIO.

This allows SCORPIO to print out timing information needed for
some types of debugging.
@xylar
Copy link
Contributor Author

xylar commented Aug 24, 2022

See discussion PR E3SM-Ocean-Discussion#30 for additional context.

@xylar
Copy link
Contributor Author

xylar commented Aug 24, 2022

Testing

I ran the compass ocean pr test suite and verified that the expected io_perf_summary_*.txt and io_perf_summary_*.json files are produced for each forward run of MPAS-Ocean. These files were previously not available.

I ran the ERS.ne11_oQU240.WCYCL1850NS.anvil_intel E3SM test and verified that timing appears as usual in the spio_stats/ subdirectory (presumably a good indication that the MPAS framework didn't erroneously finalize PIO too soon).

@xylar
Copy link
Contributor Author

xylar commented Aug 24, 2022

@jonbob, would you like me to do further E3SM testing on this to make sure I'm doing no harm? Happy to run whatever tests you suggest.

@jonbob
Copy link
Contributor

jonbob commented Aug 24, 2022

@xylar - I'll do more testing before I merge, so I think this looks fine. Thanks

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This functions for the ocean core. Tested with gnu and intel, both debug and optimized, nightly suite on badger. Also compares bfb against branch point with gnu optimized.

Copy link
Contributor

@matthewhoffman matthewhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on discussion yesterday, inspection, and Mark's testing. This appears to be the proper implementation that mirrors the init operations.

@xylar
Copy link
Contributor Author

xylar commented Sep 1, 2022

Thanks for these reviews as well, @matthewhoffman and @mark-petersen! Much appreciated.

@akturner, this is lower priority than #5162 for me but would appreciate you having a look at this soon, too, if you can.

@xylar
Copy link
Contributor Author

xylar commented Sep 1, 2022

Thanks @akturner!

@jonbob jonbob added the BFB PR leaves answers BFB label Sep 1, 2022
@jonbob
Copy link
Contributor

jonbob commented Sep 1, 2022

Test merge passes sanity testing on chrysalis:

  • SMS_D_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod
  • ERS.ne11_oQU240.WCYCL1850NS.chrysalis_intel

will merge to next as soon as the repo is open

jonbob added a commit that referenced this pull request Sep 1, 2022
…5152)

Finalize PIO when finalizing MPAS i/o in MPAS Standalone

This allows SCORPIO to print out timing information needed for some
types of debugging. pio_finalize() is only called in standalone. If MPAS
components are run as part of an E3SM run, the PIO context is passed to
MPAS and this signals that the MPAS framework should not finalize PIO.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Sep 1, 2022

merged to next

@jonbob jonbob merged commit 3b8e170 into E3SM-Project:master Sep 2, 2022
@jonbob
Copy link
Contributor

jonbob commented Sep 2, 2022

merged to master

@xylar xylar deleted the mpas-framework/call-pio-finalize branch January 29, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants