Add `-fallow-argument-mismatch` to gfortran in MPAS standalone builds #4821

xylar · 2022-03-01T16:43:36Z

This allows the code to build with gfortran >=10.0.0

Related to #4817, but for standalone MPAS builds

[BFB]

xylar · 2022-03-01T16:47:54Z

Testing

With this fix, I was able to build with gfortran 10.3.0, whereas I got errors (see MPAS-Dev/compass#323) without it.

With this fix, I successfully ran the ocean nightly test suite with gfortran 10.3.0.

I will test on Anvil with the older gfortran there to make sure this does no harm.

Update: I ran the ocean pr test suite build with gfortran 8.2.0 on Anvil using this branch and it was bit-for-bit with a baseline using the same version of gfortran and master.

xylar · 2022-03-01T17:39:29Z

This is not working for gfortran < 10, so I need to work on that.

xylar · 2022-03-01T21:49:21Z

I'm still testing this on Anvil but it does at least build with an older gfortran.

xylar · 2022-03-01T21:50:10Z

components/mpas-framework/Makefile

+	GFORTRAN_GTE_10=$$(expr `gfortran -dumpversion | cut -f1 -d.` \>= 10) ;\
+	if [ "$${GFORTRAN_GTE_10}" = "1" ]; then \
+	    FFLAGS="-fallow-argument-mismatch"; \
+	else \
+	    FFLAGS=""; \
+	fi; \
 	( $(MAKE) all \
 	"FC_PARALLEL = mpif90" \


@philipwjones, do you know of a more elegant way to do this? If so, I'm keen to learn.

No, not really.

philipwjones

You might consider using a more specific FFLAG name just to avoid confusion with the final FFLAGS variable that's created later for all flags.

But I approve regardless. This appears to be needed for gnu builds.

philipwjones · 2022-03-02T15:23:33Z

components/mpas-framework/Makefile

+	GFORTRAN_GTE_10=$$(expr `gfortran -dumpversion | cut -f1 -d.` \>= 10) ;\
+	if [ "$${GFORTRAN_GTE_10}" = "1" ]; then \
+	    FFLAGS="-fallow-argument-mismatch"; \
+	else \
+	    FFLAGS=""; \
+	fi; \
 	( $(MAKE) all \
 	"FC_PARALLEL = mpif90" \


No, not really.

xylar · 2022-03-02T17:31:29Z

You might consider using a more specific FFLAG name just to avoid confusion with the final FFLAGS variable that's created later for all flags.

Thanks @philipwjones, I completely agree. I'll give this a different name.

This allows MPAS to build with gfortran >=10

xylar · 2022-03-02T17:35:57Z

@philipwjones, I called it EXTRA_FFLAGS, instead of FFLAGS.

xylar · 2022-03-02T17:36:27Z

@mark-petersen, @akturner and @matthewhoffman, this is ready for your review.

matthewhoffman · 2022-03-08T15:50:37Z

components/mpas-framework/Makefile

@@ -296,6 +296,12 @@ intel-mpi:
 	"CPPFLAGS = $(MODEL_FORMULATION) -D_MPI" )

 gfortran:
+	GFORTRAN_GTE_10=$$(expr `gfortran -dumpversion | cut -f1 -d.` \>= 10) ;\
+	if [ "$${GFORTRAN_GTE_10}" = "1" ]; then \


Should this be single dollar sign? My understanding was that $$ accesses shell variables, but single dollar sign should be used for Makefile variables (https://stackoverflow.com/questions/26564825/what-is-the-meaning-of-a-double-dollar-sign-in-bash-makefile). If my understanding is correct, it is interesting that using $$ here still works.

The $$ is also used below on all the lines below.

@matthewhoffman, my understanding of Makefiles is pretty limited but the single dollar sign version definitely wasn't working.

My understanding it that the make targets are shell scripts, unlike the rest of the make file, and they require $$ to escape the dollar sign so you are actually making shell calls as you want to here.

If you want to try what you suggest and see if you can get it working, be my guest. I wasn't successful.

Huh. I tested the makefile but checking for version >=1 so it adds the flag. Compile dies with an error with gnu V6 (as expected) because the flag -fallow-argument-mismatch is undefined. I tried to change the double dollar signs to $(GFORTRAN_GTE_10) and $(EXTRA_FFLAGS) and it didn't work (the variables don't contain the correct values). So @xylar did it right - I just don't understand why these are shell variables rather than makefile variables.

Ok, thanks for the explanation and testing. I'm convinced. :)

mark-petersen

Tested with gnu V6 on grizzly, and it compiles fine. I also changed to check for version >= 1 and confirmed that the flag is added, since I don't have a V10 compiler to test.

mark-petersen · 2022-03-08T21:28:19Z

@akturner I compiled and tested above. Should be the same for sea ice, since we all use the same Makefile. Can you test or approve based on my comments? Thanks.

akturner

Passed MPAS-Seaice build and testing

…into next (PR #4821) Add -fallow-argument-mismatch to gfortran in MPAS standalone builds This allows the code to build with gfortran >=10.0.0 Related to #4817, but for standalone MPAS builds [BFB]

jonbob · 2022-03-14T17:55:20Z

merged to next

jonbob · 2022-03-15T16:38:04Z

merged to master

xylar · 2022-03-15T17:17:30Z

Thanks @jonbob, I really appreciate it!

xylar · 2022-03-15T17:25:16Z

Thanks @jonbob, I really appreciate it!

MPAS standalone: Add gnu >=10 support on Cori This merge adds the -fallow-argument-mismatch flag to the gnu-nersc target for MPAS standalone builds. This got missed in #4821. [BFB]

xylar added BFB PR leaves answers BFB mpas-framework GNU GNU compiler related issues labels Mar 1, 2022

xylar requested review from mark-petersen, matthewhoffman and akturner March 1, 2022 16:43

xylar assigned jonbob Mar 1, 2022

xylar force-pushed the mpas-framework/fix-standalone-gfortran-10-build branch from 5a2891f to 2092b97 Compare March 1, 2022 16:49

xylar marked this pull request as draft March 1, 2022 17:39

xylar force-pushed the mpas-framework/fix-standalone-gfortran-10-build branch 2 times, most recently from 4937211 to 85de14d Compare March 1, 2022 21:41

xylar requested a review from philipwjones March 1, 2022 21:48

xylar marked this pull request as ready for review March 1, 2022 21:48

xylar commented Mar 1, 2022

View reviewed changes

xylar changed the title ~~Add -fallow-argument-mismatch to gfortran~~ Add -fallow-argument-mismatch to gfortran in MPAS standalone builds Mar 2, 2022

philipwjones approved these changes Mar 2, 2022

View reviewed changes

Add -fallow-argument-mismatch for gfortran >=10

c3ab4e6

This allows MPAS to build with gfortran >=10

xylar force-pushed the mpas-framework/fix-standalone-gfortran-10-build branch from 85de14d to c3ab4e6 Compare March 2, 2022 17:34

matthewhoffman reviewed Mar 8, 2022

View reviewed changes

mark-petersen approved these changes Mar 8, 2022

View reviewed changes

matthewhoffman approved these changes Mar 8, 2022

View reviewed changes

akturner approved these changes Mar 14, 2022

View reviewed changes

jonbob merged commit 6daeba2 into E3SM-Project:master Mar 15, 2022

xylar deleted the mpas-framework/fix-standalone-gfortran-10-build branch March 15, 2022 17:17

This was referenced Mar 18, 2022

Update E3SM-Project submodule MPAS-Dev/compass#326

Merged

With gfortran 10.x.x, errors in MPAS-Ocean build MPAS-Dev/compass#323

Closed

MPAS standalone: Add gnu >=10 support on Cori #4854

Merged

xylar mentioned this pull request May 4, 2022

Update E3SM-Project to E3SM/master MPAS-Dev/compass#383

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `-fallow-argument-mismatch` to gfortran in MPAS standalone builds #4821

Add `-fallow-argument-mismatch` to gfortran in MPAS standalone builds #4821

xylar commented Mar 1, 2022 •

edited by jonbob

Loading

xylar commented Mar 1, 2022 •

edited

Loading

xylar commented Mar 1, 2022

xylar commented Mar 1, 2022

xylar Mar 1, 2022

philipwjones Mar 2, 2022

philipwjones left a comment

philipwjones Mar 2, 2022

xylar commented Mar 2, 2022

xylar commented Mar 2, 2022

xylar commented Mar 2, 2022

matthewhoffman Mar 8, 2022

xylar Mar 8, 2022

mark-petersen Mar 8, 2022

matthewhoffman Mar 8, 2022

mark-petersen left a comment

mark-petersen commented Mar 8, 2022

akturner left a comment

jonbob commented Mar 14, 2022

jonbob commented Mar 15, 2022

xylar commented Mar 15, 2022

xylar commented Mar 15, 2022

Add -fallow-argument-mismatch to gfortran in MPAS standalone builds #4821

Add -fallow-argument-mismatch to gfortran in MPAS standalone builds #4821

Conversation

xylar commented Mar 1, 2022 • edited by jonbob Loading

xylar commented Mar 1, 2022 • edited Loading

Testing

xylar commented Mar 1, 2022

xylar commented Mar 1, 2022

xylar Mar 1, 2022

Choose a reason for hiding this comment

philipwjones Mar 2, 2022

Choose a reason for hiding this comment

philipwjones left a comment

Choose a reason for hiding this comment

philipwjones Mar 2, 2022

Choose a reason for hiding this comment

xylar commented Mar 2, 2022

xylar commented Mar 2, 2022

xylar commented Mar 2, 2022

matthewhoffman Mar 8, 2022

Choose a reason for hiding this comment

xylar Mar 8, 2022

Choose a reason for hiding this comment

mark-petersen Mar 8, 2022

Choose a reason for hiding this comment

matthewhoffman Mar 8, 2022

Choose a reason for hiding this comment

mark-petersen left a comment

Choose a reason for hiding this comment

mark-petersen commented Mar 8, 2022

akturner left a comment

Choose a reason for hiding this comment

jonbob commented Mar 14, 2022

jonbob commented Mar 15, 2022

xylar commented Mar 15, 2022

xylar commented Mar 15, 2022

Add `-fallow-argument-mismatch` to gfortran in MPAS standalone builds #4821

Add `-fallow-argument-mismatch` to gfortran in MPAS standalone builds #4821

xylar commented Mar 1, 2022 •

edited by jonbob

Loading

xylar commented Mar 1, 2022 •

edited

Loading