Checking for an active atmosphere before modifying CAM_CONFIG_OPTS (run_acme). #1586
Conversation
We turn the COSP simulator on for watercycle simulations using $xmlchange_exe --id CAM_CONFIG_OPTS --append --val " -cosp" However, this fails for compsets with data-atmospheres. Hence, a test has been added to run_acme.template.csh to only turn COSP on when CAM_CONFIG_OPTS is in env_build.xml
|
Note: run_acme failed for an I-compset because of this issue. To make matters worse, the error message from xmlchange is misleading (see #1585). This is a workaround for run_acme. An alternative solution is to comment out the line, and rely on users to uncomment it when they want COSP. (pinging @golaz ) |
run_acme.template.csh
Outdated
| #NOTE: xmlchange has a bug which requires append to be specified with quotes and a leading space. | ||
| #NOTE: The xmlchange will fail if CAM is not active (eg a land only simulation), so we need to test that CAM_CONFIG_OPTS is in env_build.xml | ||
|
|
||
| grep CAM_CONFIG_OPTS env_build.xml >> /dev/null |
There was a problem hiding this comment.
./xmlquery can also be used here instead of grep:
./xmlquery CAM_CONFIG_OPTS >> /dev/null
There was a problem hiding this comment.
A good idea. I'll test it out.
The test for CAM_CONFIG_OPTS stopped run_acme execution because run_acme uses the 'csh -e' option, and the test returned a non-zero status when it was missing. A similiar test using xmlquery had the same problem. Hence, the test has been replaced with an xmlquery of the value of COMP_ATM; if it is 'datm' then the data atmosphere is being used. This new test is clearer, and resolves the problem. This commit also includes a template for modifying usr_nl_clm, for the convenience of users.
|
When implementing the suggestion of @singhbalwinder , I found another problem: the test for CAM_CONFIG_OPTS stopped run_acme execution because run_acme uses the 'csh -e' option, and the test returned a non-zero status when CAM_CONFIG_OPTS was missing. A similar test using xmlquery had the same problem. Hence, the test has been replaced with an xmlquery of the value of COMP_ATM; if it is 'datm' then the data atmosphere is being used. I think this new test is clearer, and it resolves the problem. This commit also includes a template for modifying usr_nl_clm, for the convenience of users. It would be nice to have a separate PR, but I don't think it is worth the effort. |
*********1*********2*********3*********4*********5*********6*********7** Longer commit message body describing the commit. Can contain lists as follows: * Item 1 * Item 2 * Item 3 A good commit message should be written like an email, a subject followed by a blank line, followed by a more descriptive body. Can also contain a tag at the bottom describing what type of commit this is. [BFB] - Bit-For-Bit [FCC] - Flag Climate Changing [Non-BFB] - Non Bit-For-Bit [CC] - Climate Changing [NML] - Namelist Changing See confluence for a more detailed description about these tags.
|
@cameronsmith1 please fix the title to something more formal and in verb noun format. |
|
Sorry I must have missed this; is this ready for merging? |
|
It would be good to get concurrence from @PeterCaldwell. And there is the need to deconflict the version number with #1594 . Otherwise, I think this is ready to go. |
There was an independent PR (#1594) which became version 3.0.9, so changing the version for this PR to 3.0.10.
|
Since PR #1594 has been merged to master, I have upped the run_acme version number for this PR to 3.0.10 @PeterCaldwell can you give this PR a quick check? |
Update cime to support full X configuration Tested with ERS.f19_g16.X.yellowstone_intel only Test suite: Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes [CIME Github issue #] 1587 User interface changes?: Code review:
Fixed issue with GET_REFCASE not being set correctly that was introduced with PR#1561 and an issue with X compset mapping files that was introduced in #1586 Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes User interface changes?: Code review:
A test has been added to run_acme.template.csh so that CAM_CONFIG_OPTS will only be modified if there is an active atmosphere model.
The problem is that we previously turned the COSP simulator on for watercycle simulations using
However, this fails for compsets with data-atmospheres (because CAM_CONFIG_OPTS doesn't exist in env_build.xml .
I also added a dummy usr_nl_clm for the convenience of users.