From 2a7ab845031281099b34c0469e4faeb83836cbdd Mon Sep 17 00:00:00 2001
From: Luca Bertagna <lbertag@sandia.gov>
Date: Wed, 18 Sep 2024 14:09:56 -0600
Subject: [PATCH 1/3] EAMxx: fix kokkos 4 deprecated code

---
 components/eamxx/src/physics/p3/tests/p3_find_unit_tests.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/eamxx/src/physics/p3/tests/p3_find_unit_tests.cpp b/components/eamxx/src/physics/p3/tests/p3_find_unit_tests.cpp
index 82ca006d76da..4ba2dc6760e7 100644
--- a/components/eamxx/src/physics/p3/tests/p3_find_unit_tests.cpp
+++ b/components/eamxx/src/physics/p3/tests/p3_find_unit_tests.cpp
@@ -28,7 +28,7 @@ static void run()
 {
   const int max_threads =
 #ifdef KOKKOS_ENABLE_OPENMP
-    Kokkos::OpenMP::concurrency()
+    Kokkos::OpenMP().concurrency()
 #else
     1
 #endif

From 073ed9f2bff462815f38ffe0a877e63366c63c55 Mon Sep 17 00:00:00 2001
From: Luca Bertagna <lbertag@sandia.gov>
Date: Wed, 9 Oct 2024 14:57:55 -0600
Subject: [PATCH 2/3] Fix settings of ghci machine at snl

* Add entry in config_machines.xml
* Renamed to ghci-snl-cpu
* Fix baselines location
---
 cime_config/machines/config_machines.xml      | 42 +++++++++++++++++++
 .../cmake/machine-files/ghci-snl-cpu.cmake    |  5 +++
 .../cmake/machine-files/ghci-snl-openmp.cmake |  9 ----
 components/eamxx/scripts/machines_specs.py    | 10 ++---
 4 files changed, 52 insertions(+), 14 deletions(-)
 create mode 100644 components/eamxx/cmake/machine-files/ghci-snl-cpu.cmake
 delete mode 100644 components/eamxx/cmake/machine-files/ghci-snl-openmp.cmake

diff --git a/cime_config/machines/config_machines.xml b/cime_config/machines/config_machines.xml
index b6101b322125..598989167e01 100644
--- a/cime_config/machines/config_machines.xml
+++ b/cime_config/machines/config_machines.xml
@@ -1633,6 +1633,48 @@ commented out until "*** No rule to make target '.../libadios2pio-nm-lib.a'" iss
     </environment_variables>
   </machine>
 
+  <machine MACH="ghci-snl-cpu">
+    <DESC>Huge Linux workstation for Sandia climate scientists</DESC>
+    <NODENAME_REGEX>^[a-fA-F0-9]{12}$</NODENAME_REGEX>
+    <OS>LINUX</OS>
+    <PROXY>proxy.sandia.gov:80</PROXY>
+    <COMPILERS>gnu</COMPILERS>
+    <MPILIBS>openmpi</MPILIBS>
+    <CIME_OUTPUT_ROOT>/projects/e3sm/scratch</CIME_OUTPUT_ROOT>
+    <DIN_LOC_ROOT>/projects/e3sm/inputdata</DIN_LOC_ROOT>
+    <DIN_LOC_ROOT_CLMFORC>/projects/e3sm/inputdata/atm/datm7</DIN_LOC_ROOT_CLMFORC>
+    <DOUT_S_ROOT>$CIME_OUTPUT_ROOT/archive/$CASE</DOUT_S_ROOT>
+    <BASELINE_ROOT>/projects/e3sm/baselines/ghci-snl-cpu/$COMPILER</BASELINE_ROOT>
+    <CCSM_CPRNC>/projects/e3sm/cprnc/cprnc</CCSM_CPRNC>
+    <GMAKE_J>32</GMAKE_J>
+    <TESTS>e3sm_developer</TESTS>
+    <BATCH_SYSTEM>none</BATCH_SYSTEM>
+    <SUPPORTED_BY>lbertag at sandia dot gov</SUPPORTED_BY>
+    <MAX_TASKS_PER_NODE>32</MAX_TASKS_PER_NODE>
+    <MAX_MPITASKS_PER_NODE>32</MAX_MPITASKS_PER_NODE>
+    <mpirun mpilib="default">
+      <executable>mpirun</executable>
+      <arguments>
+        <arg name="binding"> --bind-to core</arg>
+      </arguments>
+    </mpirun>
+    <module_system type="none"/>
+    <RUNDIR>$CIME_OUTPUT_ROOT/$CASE/run</RUNDIR>
+    <EXEROOT>$CIME_OUTPUT_ROOT/$CASE/bld</EXEROOT>
+    <TEST_TPUT_TOLERANCE>0.1</TEST_TPUT_TOLERANCE>
+    <MAX_GB_OLD_TEST_DATA>0</MAX_GB_OLD_TEST_DATA>
+    <environment_variables>
+      <env name="NETCDF_C_PATH">$ENV{NETCDF_C_ROOT}</env>
+      <env name="NETCDF_FORTRAN_PATH">$ENV{NETCDF_FORTRAN_ROOT}</env>
+      <env name="PNETCDF_PATH">$ENV{PARALLEL_NETCDF_ROOT}</env>
+      <env name="OMP_STACKSIZE">64M</env>
+      <env name="OMP_PROC_BIND">spread</env>
+      <env name="OMP_PLACES">threads</env>
+      <env name="BLA_VENDOR">Generic</env>
+      <env name="GATOR_INITIAL_MB">4000MB</env>
+    </environment_variables>
+  </machine>
+
   <machine MACH="weaver">
     <DESC>Sandia GPU testbed</DESC>
     <NODENAME_REGEX>weaver</NODENAME_REGEX>
diff --git a/components/eamxx/cmake/machine-files/ghci-snl-cpu.cmake b/components/eamxx/cmake/machine-files/ghci-snl-cpu.cmake
new file mode 100644
index 000000000000..2fd6a9cbb426
--- /dev/null
+++ b/components/eamxx/cmake/machine-files/ghci-snl-cpu.cmake
@@ -0,0 +1,5 @@
+# Common settings for our ghci images
+include(${CMAKE_CURRENT_LIST_DIR}/ghci-snl.cmake)
+
+# Set SCREAM_MACHINE
+set(SCREAM_MACHINE ghci-snl-cpu CACHE STRING "")
diff --git a/components/eamxx/cmake/machine-files/ghci-snl-openmp.cmake b/components/eamxx/cmake/machine-files/ghci-snl-openmp.cmake
deleted file mode 100644
index 3139580e9ee0..000000000000
--- a/components/eamxx/cmake/machine-files/ghci-snl-openmp.cmake
+++ /dev/null
@@ -1,9 +0,0 @@
-# Common settings for our ghci images
-include(${CMAKE_CURRENT_LIST_DIR}/ghci-snl.cmake)
-
-# Set SCREAM_MACHINE
-set(SCREAM_MACHINE ghci-snl-openmp CACHE STRING "")
-
-# Set OpenMP backend
-set(EKAT_MACH_FILES_PATH ${CMAKE_CURRENT_LIST_DIR}/../../../../externals/ekat/cmake/machine-files)
-include (${EKAT_MACH_FILES_PATH}/kokkos/openmp.cmake)
diff --git a/components/eamxx/scripts/machines_specs.py b/components/eamxx/scripts/machines_specs.py
index 9cf079dafa66..5de7ec266da2 100644
--- a/components/eamxx/scripts/machines_specs.py
+++ b/components/eamxx/scripts/machines_specs.py
@@ -93,11 +93,11 @@
     "linux-generic" :        ([],["mpicxx","mpifort","mpicc"],"", ""),
     "linux-generic-debug" :  ([],["mpicxx","mpifort","mpicc"],"", ""),
     "linux-generic-serial" : ([],["mpicxx","mpifort","mpicc"],"", ""),
-    "ghci-snl-openmp" : ([],
-                         ["mpicxx","mpifort","mpicc"],
-                         "",
-                         "/projects/e3sm/baselines/scream/master-baselines"
-                        ),
+    "ghci-snl-cpu" : ([],
+                      ["mpicxx","mpifort","mpicc"],
+                      "",
+                      "/projects/e3sm/baselines/scream/ghci-snl-cpu"
+                     ),
 }
 
 if pathlib.Path("~/.cime/scream_mach_specs.py").expanduser().is_file(): # pylint: disable=no-member

From 5ac2f948bc2d58872d632f2a2c1d32f43a423e0b Mon Sep 17 00:00:00 2001
From: Luca Bertagna <lbertag@sandia.gov>
Date: Thu, 24 Oct 2024 15:04:37 -0600
Subject: [PATCH 3/3] Add num_tasks arg for mpirun on ghci-snl-cpu

---
 cime_config/machines/config_machines.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cime_config/machines/config_machines.xml b/cime_config/machines/config_machines.xml
index 598989167e01..5bed00ea5d5a 100644
--- a/cime_config/machines/config_machines.xml
+++ b/cime_config/machines/config_machines.xml
@@ -1656,6 +1656,7 @@ commented out until "*** No rule to make target '.../libadios2pio-nm-lib.a'" iss
       <executable>mpirun</executable>
       <arguments>
         <arg name="binding"> --bind-to core</arg>
+        <arg name="num_tasks"> -np {{ total_tasks }}</arg>
       </arguments>
     </mpirun>
     <module_system type="none"/>