Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid ip addresses are being marked as local #3

Open
patrickkettner opened this issue Oct 11, 2017 · 4 comments
Open

invalid ip addresses are being marked as local #3

patrickkettner opened this issue Oct 11, 2017 · 4 comments

Comments

@patrickkettner
Copy link

e.g. 127.0.0.999999999
@DylanPiercey
Copy link
Owner

😱 Hopefully I'll get some time to dig into this tomorrow. A PR would be great though, thanks for pointing it out!

@patrickkettner
Copy link
Author

patrickkettner commented Oct 11, 2017 •
edited
Loading

No worries
For the 127 specific case, you can use something like

^127.(.(([01]?[0-9]?[0-9])|(2[0-4][0-9])?|(25[0-5]))){3}$

haven't had a chance to look into edge cases on the other ranges yet, however.

explanation diagram

@Chaphasilor
Copy link

😱 Hopefully I'll get some time to dig into this tomorrow.

It's been 1394 days. Have you had a chance to look into this? :P

@DylanPiercey
Copy link
Owner

I am not actively using or maintaining this module. Given a well tested PR I would consider merging and/or adding collaborators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patrickkettner @DylanPiercey @Chaphasilor