Skip to content
This repository was archived by the owner on Mar 3, 2022. It is now read-only.

Add "client_authentication" parameter to index.d.ts #1313

Open
andioli opened this issue Feb 26, 2021 · 3 comments
Open

Add "client_authentication" parameter to index.d.ts #1313

andioli opened this issue Feb 26, 2021 · 3 comments

Comments

@andioli
Copy link

andioli commented Feb 26, 2021

First of all, thank you for adding basic authentication with #1060.

Yet, the client_authentication parameter is still missing in the index.d.ts file. It would be great, if you could add this line:
client_authentication: string to OidcClientSettings.

Without this parameter, it's not really usable with Typescript projects.

Thanks in advance! :)

@brockallen
Copy link
Contributor

Feel free to send a PR, please?

@frontendplace
Copy link

frontendplace commented May 5, 2021

it should be: client_authentication? : string

can anybody make PR for this: in node_modules/oidc-client/index.d.ts
I am not allowed to push changes

line 126:
export interface OidcClientSettings {
/** The URL of the OIDC/OAuth2 provider /
authority?: string;
readonly metadataUrl?: string;
/
* Provide metadata when authority server does not allow CORS on the metadata endpoint /
metadata?: Partial;
/
* Provide signingKeys when authority server does not allow CORS on the jwks uri /
signingKeys?: any[];
/
* Your client application's identifier as registered with the OIDC/OAuth2 /
client_id?: string;
client_secret?: string;
/
* The DefaultClientAuthentication is 'client_secret_post' and can be set back to standard 'client_secret_basic' /
client_authentication? : string
/
* The type of response desired from the OIDC/OAuth2 provider (default: 'id_token') */

@willmcclellan
Copy link

Added this in #1390

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants