Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #213

Closed
7 of 37 tasks
ioBroker-Bot opened this issue Sep 11, 2024 · 17 comments
Closed
7 of 37 tasks

Please consider fixing issues detected by repository checker #213

ioBroker-Bot opened this issue Sep 11, 2024 · 17 comments

Comments

@ioBroker-Bot
Copy link

ioBroker-Bot commented Sep 11, 2024

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter esphome for common errors and appropiate suggestions to keep this adapter up to date.

This check is based on the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.esphome

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

ERRORS:

  • ❗ [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended
  • ❗ [E026] "{'engines': {'node'>='18'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended
  • ❗ [E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json
  • ❗ [E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.2.2 is recommended. Please update dependencies at package.json
  • ❗ [E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.2.3 is recommended. Please update dependencies at package.json
  • ❗ [E036] @iobroker/testing 4.1.0 specified. 4.1.3 is required as minimum, 4.1.3 is recommended. Please update devDependencies at package.json
  • ❗ [E036] @iobroker/testing 4.1.0 specified. 4.1.3 is required as minimum, 5.0.0 is recommended. Please update devDependencies at package.json
  • ❗ [E136] No "common.news" found for actual version 0.5.0-beta.10 in io-package.json
  • ❗ [E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
  • ❗ [E157] js-controller 3.3.22 listed as dependency but 5.0.19 is required as minimum. Please update dependency at io-package.json.
  • ❗ [E184] "common.subscribe" will be removed with js-controller >= 6. Please remove from io-package.json and adapt code if required.
  • ❗ [E507] missing size attributes [xs,sm,md,lg,xl] for staticLink at admin/jsonConfig.json5/items/_options/headerESPHomeDashboard-details-api.proto
  • ❗ [E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/emptyLine-6
  • ❗ [E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-1
  • ❗ [E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-2
  • ❗ [E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-3
  • ❗ [E510] responsive check: maximum issues reached, please fix reported ones and recheck
  • ❗ [E606] Current adapter version 0.5.0-beta.10 not found in README.md
  • ❗ [E804] Please process issue [#214] "Compatibility check and testing for node.js 22"

WARNINGS:

  • 👀 [W040] "keywords" within package.json should contain "ioBroker"
  • 👀 [W048] devDependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "promisify:0.0.3"
  • 👀 [W127] Missing suggested translation into uk of "common.titleLang" in io-package.json.
  • 👀 [W134] Missing suggested translation into uk of "common.desc" in io-package.json.
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }
  • 👀 [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
  • 👀 [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.
  • 👀 [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
  • 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
  • 👀 [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
  • 👀 [W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.4.1)
  • 👀 [W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.5.0-beta.8)
  • 👀 [W508] attribute "xs" for autocompleteSendTo should specify a value of "12" at admin/jsonConfig.json5/items/devices/deviceIP
  • 👀 [W508] attribute "xs" for password should specify a value of "12" at admin/jsonConfig.json5/items/devices/apiPassword
  • 👀 [W508] attribute "xs" for password should specify a value of "12" at admin/jsonConfig.json5/items/devices/encryptionKey
  • 👀 [W510] "/admin/i18n/uk/translations.json" or "admin/i18n/uk.json" not found, but admin support is declared. Please add.
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
  • 👀 [W953] .npmignore found - consider using package.json object "files" instead.

👍 No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck
or
@iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 17 Jan 2025 03:57:53 GMT based on commit 8ca51cd
ioBroker.repochecker 3.2.4

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E955] iob_npm.done not found in .npmignore

👍Thanks for fixing the issues.

The following issues are new and have been added
[E011] "@iobroker/dev-server" must not be listed as dependency at package.json

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E011] "@iobroker/dev-server" must not be listed as dependency at package.json

👍Thanks for fixing the issues.

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.

👍Thanks for fixing the issues.

The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

1 similar comment
@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.

👍Thanks for fixing the issues.

The following issues are new and have been added
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Executable is defined by entry "main" at package.json.

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.5.0-beta.8)

👍Thanks for fixing the issues.

The following issues are new and have been added
[W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.4.1)

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.4.1)

👍Thanks for fixing the issues.

The following issues are not fixed and have been reopened
[W252] Version of package.json (0.5.0-beta.10) doesn't match latest version on NPM (0.5.0-beta.8)

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended

👍Thanks for fixing the issues.

The following issues are new and have been added
[E026] "{'engines': {'node'>='18'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json

👍Thanks for fixing the issues.

The following issues are new and have been added
[E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.2.2 is recommended. Please update dependencies at package.json

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues are new and have been added
[E507] missing size attributes [xs,sm,md,lg,xl] for staticLink at admin/jsonConfig.json5/items/_options/headerESPHomeDashboard-details-api.proto
[E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/emptyLine-6
[E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-1
[E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-2
[E507] missing size attributes [xs,sm,md,lg,xl] for staticText at admin/jsonConfig.json5/items/_options/headerHowToConnect-details-3
[E510] responsive check: maximum issues reached, please fix reported ones and recheck
[E804] Please process issue [#214] "Compatibility check and testing for node.js 22"
[W508] attribute "xs" for autocompleteSendTo should specify a value of "12" at admin/jsonConfig.json5/items/devices/deviceIP
[W508] attribute "xs" for password should specify a value of "12" at admin/jsonConfig.json5/items/devices/apiPassword
[W508] attribute "xs" for password should specify a value of "12" at admin/jsonConfig.json5/items/devices/encryptionKey

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.

👍Thanks for fixing the issues.

The following issues are new and have been added
[E157] js-controller 3.3.22 listed as dependency but 5.0.19 is required as minimum. Please update dependency at io-package.json.

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.2.2 is recommended. Please update dependencies at package.json
[E036] @iobroker/testing 4.1.0 specified. 4.1.3 is required as minimum, 4.1.3 is recommended. Please update devDependencies at package.json

👍Thanks for fixing the issues.

The following issues are new and have been added
[E033] @iobroker/adapter-core 3.0.4 specified. 3.1.4 is required as minimum, 3.2.3 is recommended. Please update dependencies at package.json
[E036] @iobroker/testing 4.1.0 specified. 4.1.3 is required as minimum, 5.0.0 is recommended. Please update devDependencies at package.json

@SimonFischer04
Copy link
Contributor

@DutchmanNL sorry for mention but maybe it reaches this way.

Is this adapter still be planned to work on. (F.e. all the things discussed in ~November: typescript, dashboard version handling, releading to stable,...)
?

@mcm1957
Copy link
Contributor

mcm1957 commented Jan 17, 2025

@DutchmanNL sorry for mention but maybe it reaches this way.

Is this adapter still be planned to work on. (F.e. all the things discussed in ~November: typescript, dashboard version handling, releading to stable,...) ?

You should create a dedicated Issue for this. The adapter checker cannot answer this question.

@mcm1957
Copy link
Contributor

mcm1957 commented Jan 17, 2025

@ioBroker-Bot recreate

@SimonFischer04
Copy link
Contributor

@DutchmanNL sorry for mention but maybe it reaches this way.

Is this adapter still be planned to work on. (F.e. all the things discussed in ~November: typescript, dashboard version handling, releading to stable,...) ?

You should create a dedicated Issue for this. The adapter checker cannot answer this question.

Sorry,
didn't mean to trigger the bot. I don't want the bot to answer, that's why I tagged. @DutchmanNL.

I thought with all the issues found by the checker it is time to continue with the adapter.

@ioBroker-Bot
Copy link
Author

Thanks for contacting me.
I received your request to recheck this repository and to recreate the checker issue. I will start doing my work soon.
I will close an existing issue and create a new one if any issues are to be reported.

Thanks for spending your time and working at an ioBroker adapter.

your
ioBroker Check and Service Bot

@ioBroker-Bot
Copy link
Author

Issue outdated due to RECREATE request. Follow up issue #223 has been created.
This issue will be closed.

your
ioBroker Check and Service Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants