Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1115 should allow comments between parameters. #1921

Closed
vweijsters opened this issue Dec 4, 2015 · 4 comments
Closed

SA1115 should allow comments between parameters. #1921

vweijsters opened this issue Dec 4, 2015 · 4 comments
Assignees
Milestone

Comments

@vweijsters
Copy link
Contributor

The following code should not produce SA1115, but it currently does:

    public void MyTest(int v1, int v2, int v3)
    {
    }

    public void TestMethod()
    {
        this.MyTest(
            1,
            /* comment */
            2,
            /* comment */
            3);
    }

The same construction should probably also be allowed for //// comments. // comments will not work because they require an empty line before them and that will (and shall) trigger SA1115.

@sharwell
Copy link
Member

What does StyleCop Classic do in this case?

@sharwell sharwell modified the milestones: 1.1.0, Backlog Dec 17, 2015
@vweijsters
Copy link
Contributor Author

The code above is accepted by StyleCop Classic without warnings.

@sharwell
Copy link
Member

Thanks, changing this to a 🐛.

@vweijsters
Copy link
Contributor Author

Grabbing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants