Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/Client state machine broken after upgrade to socket.io@4 #526

Closed
2 tasks done
Domiii opened this issue May 27, 2021 · 1 comment
Closed
2 tasks done

runtime/Client state machine broken after upgrade to socket.io@4 #526

Domiii opened this issue May 27, 2021 · 1 comment
Assignees
@Domiii
Labels
bug Something isn't working priority

Comments

@Domiii
Copy link
Owner

Domiii commented May 27, 2021 •
edited
Loading

We just upgraded to socket.io@4. For some reason, disconnect and init_ack behavior is not as before. It sometimes connects multiple times in rapid succession, and then sends data before init_ack was received.

It's probably a race condition where the second client instant receives the first instance's init_ack somehow.

  • Investigate why
  • Fix it.
@Domiii Domiii added bug Something isn't working priority labels May 27, 2021
@Domiii Domiii self-assigned this May 27, 2021
@Domiii
Copy link
Owner Author

Domiii commented May 28, 2021 •
edited
Loading

Actually caused by socketio/socket.io#3946.
Solved by downgrading back to socket.io@2.

@Domiii Domiii closed this as completed May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Domiii Domiii

Labels
bug Something isn't working priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Domiii