Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Engine crash on shutdown with DebugDraw3D #65

Closed
yash3ahuja opened this issue Feb 7, 2025 · 3 comments
Closed

[Bug]: Engine crash on shutdown with DebugDraw3D #65

yash3ahuja opened this issue Feb 7, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@yash3ahuja
Copy link

yash3ahuja commented Feb 7, 2025

Godot version

4.3.1.rc.mono

DebugDraw3D version

1.4.5

On which operating systems the error occurs

No response

Using which renderers the error occurs

No response

Issue description

Hello,

I'm seeing a shutdown crash when using DebugDraw3D. I checked around to see if it was a Godot-side issue, and it seems someone else has also run into the same issue: godotengine/godot#101465

In that issue, they mention that the issue is caused by GDExtension and that godot-cpp needs to be updated to include this
commit which should be present in the 4.2 branch of godot-cpp: godotengine/godot-cpp#1458

The plugin seems to be currently on the godot-cpp version targeting 4.1 (corresponding commit: https://github.com/godotengine/godot-cpp/tree/4d5d707d60aac3ecb4d3e413c840448fb1356264).

Steps to reproduce

  1. Open project using DebugDraw3D with the debugger attached to the Godot editor.
  2. Immediately close the project.
  3. Observe that the debugger hits an access violation in Object::~Object() on trying to clean up instance bindings.

Minimal reproduction project

debugdrawcrash-project.zip

@yash3ahuja yash3ahuja added the bug Something isn't working label Feb 7, 2025
@DmitriySalnikov
Copy link
Owner

1.4.5 uses a different version of godot-cpp https://github.com/godotengine/godot-cpp/tree/a4f9d22ac54e05ca6a41d54a59afd7555cb7d292
And this version really leads to a crash. But at first I couldn't reproduce this problem on the latest version of the library and in godot 4.3 and 4.4.

Can you check 1.4.6?

Regarding the upgrade to 4.2, I will most likely update godot-cpp for the next release, if this does not lead to new crashes.

Moreover, godot 4.1 with my library was launched only 81 times in 6 months and 0 times in the last month (actually, it seemed to me that 4.3 is still not that common 😅).
Image

@yash3ahuja
Copy link
Author

Thank you for the prompt response. 1.4.6 seems like it fixes the issue! When do you expect it to be formally released? (I can use the updated binary that you linked in the meantime).

@DmitriySalnikov
Copy link
Owner

@yash3ahuja my main goal right now is to add 3d text support. All that remains is to implement a fast reuse of the already created text and fix the deletion timers in the physics frames. Then I will make other minor changes.

It may take a few days or weeks, and I hope to complete it as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants