Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target new Tab instead of pop-up windows #405

Open
Guy-Sowden opened this issue Sep 3, 2020 · 2 comments
Open

Target new Tab instead of pop-up windows #405

Guy-Sowden opened this issue Sep 3, 2020 · 2 comments

Comments

@Guy-Sowden
Copy link

Target new tab instead of pop-up windows for when opening proofreading menu,
pop up windows are now blocked by default in most browsers, and are seen a nuisance for users

function newProofWin(winURL){ nwWin=window.open(winURL,'_blank'); }

I think there may have to be some minor changes to the layout to adjust scaling

@cpeel
Copy link
Member

cpeel commented Sep 3, 2020

Yes, we need to revisit this. This code was created well before the advent of tabs.

@cpeel
Copy link
Member

cpeel commented Jan 16, 2021

In Dec 2020 we changed it such that by default, new user profiles have "launch in new window" set to "no". We did not change existing users' profiles, however.

When we have a new proofreading interface I suspect we will remove this option entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants