Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs and API to clarify the purpose of MeasureFunc #214

Open
Weibye opened this issue Aug 5, 2022 · 0 comments
Open

Improve docs and API to clarify the purpose of MeasureFunc #214

Weibye opened this issue Aug 5, 2022 · 0 comments
Labels
code quality Make the code cleaner or prettier. documentation Improvements or additions to documentation usability Make the library more comfortable to use

Comments

@Weibye
Copy link
Collaborator

Weibye commented Aug 5, 2022

A few notes from my work on CSS grid that relates to MeasureFunc:

  • For Grid, we will want to be able to pass a "sizing constraint" (MinContent or >MaxContent) as an alternative to a size (or in addition to an indefinite size).
  • CSS calls the result of it's equivalent of a "MeasureFunc" an item's "intrinsic size" when sized under such constraints
  • Finally, perhaps obvious to some, but MeasureFuncs only ever apply to leaf nodes and are ignored on Flex nodes. We may wish to make this clearer in the API and/or docs!

Originally posted by @nicoburns in #57 (comment)

@Weibye Weibye added documentation Improvements or additions to documentation code quality Make the code cleaner or prettier. usability Make the library more comfortable to use labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Make the code cleaner or prettier. documentation Improvements or additions to documentation usability Make the library more comfortable to use
Projects
None yet
Development

No branches or pull requests

1 participant