Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent LPUSH: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 ) #961

Closed
surya0180 opened this issue Oct 5, 2024 · 5 comments
Assignees

Comments

@surya0180
Copy link
Contributor

Steps to reproduce

Please refer to this screenshot. Left side is RedisCLI and right side is DiceCLI
image

Expected output

The expected output when the above set of commands (maybe when run on Redis)

(integer) 1

Observed output

The observed output when the above set of commands when run on DiceDB

(integer) b'OK'

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behavior
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@surya0180 surya0180 changed the title Inconsistent {CMD}: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 ) Inconsistent {LPUSH}: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 ) Oct 5, 2024
@surya0180 surya0180 changed the title Inconsistent {LPUSH}: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 ) Inconsistent LPUSH: Command in Dice docs isn't matching while running it via dicedb-cli ( #835 ) Oct 5, 2024
@bhima2001
Copy link
Contributor

I would love to work on this

@RishabhC-137
Copy link

@surya0180 can i take this?

@AshwinKul28
Copy link
Contributor

Based on the first comment assigning it to @bhima2001

@RishabhC-137 thanks for showing up interest, please check other opened issues.

@bhima2001
Copy link
Contributor

#969 --> Please find the PR attached.

@lucifercr07
Copy link
Contributor

Closing, merged as part of #969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants