-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IronHawk Port: EXISTS
command
#1430
Labels
Comments
Could you assign this issue to me? |
Is someone already working on this? I want to wok on this. |
Yes, I am working on this |
Hi @helios2003 , are you still working on this? |
Yes, I have asked a doubt I faced on the Discord. Also I remain relatively busy during the weekdays and can make progress during weekends. Thanks for understanding. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We reimplemented the core of the DiceDB engine and re-wrote - the wire protocol, execution engine, and config management. This rewrite helped us gain 32% throughput over our existing benchmark. One of the core principles we focussed on was to make code easy to extend and debug. As an effort, we need to migrate the command from the old engine to IronHawk.
Here are the exact things to be taken care of to migrate the command
EXISTS
Steps to execute
Start the DiceDB server with IronHawk engine
Start the DiceDB CLI with the IronHawk engine
Porting the command
evalEXISTS
. ex:evalSET
,evalGET
, etc. Most of them are present in thestore_eval.go
file.internal/cmd/cmd_exists.go
and follow the structure ascmd_get.go
,cmd_set.go
, andcmd_ping.go
files.evalEXISTS
function into a new file, Make a note of the return values of the new function.TODO
in the comment, if you feel there are things that need to be implemented latereval
functionNo need to write test cases for this new implementation. We will take care of this in one shot later. If the test fails, it is okay.
If you find any other bug while you are implementing it, you can either
Follow the contribution guidelines
These are general guidelines to follow before you submit a patch. Please mark them as done
once you complete them
make lint
on your local copy of the codebaseThe text was updated successfully, but these errors were encountered: